Skip to content

webview in tabcontrol #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devinZhou102 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

webview in tabcontrol #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Source/Avalonia.WebView/WebView-Core.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,15 @@ async Task<bool> Navigate(Uri? uri)
return false;
}

return _platformWebView.Navigate(uri);
if (_platformWebView is null)
return false;
try
{
return _platformWebView.Navigate(uri);
}catch (Exception ex)
{
return false;
}
}

async Task<bool> NavigateToString(string? htmlContent)
Expand Down
3 changes: 2 additions & 1 deletion Source/Avalonia.WebView/WebView-Override.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ protected override async void OnAttachedToVisualTree(VisualTreeAttachmentEventAr
protected override void OnDetachedFromVisualTree(VisualTreeAttachmentEventArgs e)
{
base.OnDetachedFromVisualTree(e);
Child = null;
//Child = null;
_partInnerContainer.Child = null;
_platformWebView?.Dispose();
_platformWebView = null;
}
Expand Down
9 changes: 8 additions & 1 deletion Source/Sample/SampleWebView/SampleWebView/Views/MainWindow.axaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,12 @@
x:Class="SampleWebView.Views.MainWindow"
Icon="/Assets/avalonia-logo.ico"
Title="SampleWebView">
<views:MainView />
<TabControl x:Name="tabControl" TabStripPlacement="Top" >
<TabItem Header="Tab 1">
<views:MainView />
</TabItem>
<TabItem Header="Tab 2">
<views:MainView />
</TabItem>
</TabControl>
</Window>