CompatHelper: bump compat for NamedDims to 1, (keep existing compat)#118
Open
github-actions[bot] wants to merge 1 commit intomasterfrom
Open
Conversation
Contributor
|
Please merge this? It's been a long time. |
Owner
|
I am sorry, it slipped through the cracks. Could you quickly resolve the conflict and then I run the tests and merge. |
PhyX-Meow
approved these changes
Nov 6, 2023
Contributor
PhyX-Meow
left a comment
PhyX-Meow
left a comment
There was a problem hiding this comment.
Well... I can not see any conflicts, to be honest.
Contributor
|
Let me create a new pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
NamedDimspackage from0.2, 0.3to0.2, 0.3, 1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.