Open
Conversation
jothaen
suggested changes
Oct 19, 2018
| @@ -8,6 +8,7 @@ interface MainContract { | |||
|
|
|||
| interface Router : BaseContract.Router{ | |||
| import pl.skipcode.basekotlinapp.feature.commons.BaseContract | ||
|
|
||
| interface AboutContract { | ||
|
|
|
|
||
| @Provides | ||
| fun providePresenter( | ||
| fragment: AboutFragment, |
There was a problem hiding this comment.
tutaj bym dał view: AboutContract.View
| )) | ||
| } | ||
|
|
||
| override fun openAbout() { |
There was a problem hiding this comment.
mozesz zrobic override fun openAbout() = router.goToAboutFragment(), ladniej wyglada
| presenter.logoutUser() | ||
| } | ||
|
|
||
| override fun clickUsername() { |
There was a problem hiding this comment.
wywaliłbym te jednolinijkowe metody clickLogout() clickUsername() itd i po prostu w onClicku wywolywalbym presenter.costam(), to prawdopodobnie zrobiles na potrzeby testow, ale imho to nadmiarowe i zaciemnia kod
| } | ||
|
|
||
| override fun goToAboutFragment() { | ||
| activity.pushFragment(AboutFragment(), BaseActivity.ANIM.FADE_IN) |
There was a problem hiding this comment.
w jednej linijce bym to robił override fun goToAboutFragment() = activity.pushFragment(....)
| fun showMessage(message: Int) | ||
| fun clickLogout() | ||
| fun clickUsername() | ||
| fun updateUsernameUI(username: String) |
There was a problem hiding this comment.
tą metodę bym nazwał setUsernameText(username: String), bo tylko to ona robi i ta nazwa bardziej pasi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.