Add hotlinking anchor tags to each table header#9
Add hotlinking anchor tags to each table header#9Kamori wants to merge 2 commits intoMichaelangel007:masterfrom
Conversation
Kamori
changed the title
|
I've updated it to instead use table of contents, rather than hotlinking the This also moves the |
|
I don't use a linter since I custom format all the html for readability. i.e. I'll align columns with extra whitespace, insert The sidebar TOC is a great idea! I'm currently in the middle of adding a gem table but I'll (hopefully) take a look at this later tonight once I verify the 1-column and 2-column mode work correctly across desktop and mobile. I test resizing the browser window width on these monitors/resolutions and platforms:
Thanks for the suggestion of moving the Javascript to the bottom. The hack of using a timer shouldn't be needed -- that's what |
|
Appreciate ya! The TOC won't support resizing as is :( Mainly because I used a fixed location settings in CSS. I could redo this to support resizing, just would take more time.
For me personally, this made it harder to assist :( But, its your project I am more than happy to adhere to your style :) And as for
Yea the only reason I did this is because of how the renderer loads the dom. Since I was injecting hash tags, I needed more control over the order the process was ran in. Since I moved to the Table of Contents view, that became less necessary to do. We can remove that change if we want to. |
|
Gem table finally got added so I can circle around to this tonight. I'll probably clone your repo and do some 1 and 2 column testing. My main concern is making sure a screen width of 1920 looks good. Only deal breaker right now (trivial as it is) is the brace style. I use Allman style. Please fix that. I'm actually excited about this PR as this make linking SO much more user friendly -- for others and myself! :-) |
2 participants
This allows you to send urls like
http://127.0.0.1:5500/index.html#table.shoppingto your friend, and have them pointed directly to the shopping table.Thanks for making this.
ps, my vscode is trying to make a lot of formatting changes. Perhaps either linting the html or providing a linting config would be appreciated :)