-
Notifications
You must be signed in to change notification settings - Fork 6
Provide cc support #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
08528a9 to
2772fef
Compare
|
MiaMark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, assuming you are able to test and resolve the question in the first file.
|
@LaithSaq Can you please fix your line ending settings and rebase, so there are no unnecessary line ending changes in the changeset? |
That's me actually "fixing" the line endings. I set my git client to checkout Windows style (CRLF) and commit Unix style (LF). The unnecessary changes you're noticing are caused by the fact that files didn't have consistent line endings to begin with. Do you suggest I re-use CRLF in files that originally used that? UPDATE: UPDATE: |
Line endings were not changed within this formatting to avoid making the change log huge for reviewing purposes.
89bc8f7 to
57bfae0
Compare
7dac281 to
d68d833
Compare
dd05338 to
141e50c
Compare
leo-labs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments that can be resolved in follow up issues.
Great job, thanks for adding this feature :) 🚀
141e50c to
2a62588
Compare
Co-authored-by: zzirnheld-mia <zzirnheld@mia.school>
2a62588 to
9d30a41
Compare
Short Summary of the Issue
Currently, the
EmailMessageAPI does not support CC recipients. Related issue #37Changes made to Resolve the Issue
EmailMessageAPI to support CCs. This is done by levereging the CCs property provided by MimeMessage.Backward Compatibility Testing
To ensure the changes do not break pending emails in the queue (with the old format lacking CC), the following steps were performed:
MemoryStorageinstead ofElasticfor simplified local testing.master).tools/EmailMessageGenerator.smtp4dev.This enabled me to verify that emails without CCs will have a
nullCC value when parsing emails into the new type. Herenullchecks and using empty lists saves the program from throwing a null reference exception.It also works the other way around (swapping the old/new types). It just drops the added field entirely when parsing into a type with no CC.
I've tested with many more scenarios and as long as the exchange is created, no emails are being dropped and no parsing is failing. Which aligns with this warning
Additional Validation in Elasticsearch
curl http://127.0.0.1:9200/_cat/indices?vdocs.countto confirm email tracking._searchand confirmed that CC fields are correctly stored in the new format:Release Notes
Technical Improvements
EmailMessageAPI.Checklist