Skip to content

Add configurable DIRECTORY_NAME for rclone (Now compatible with S3 providers)#55

Open
BestPig wants to merge 1 commit intoMiSTer-devel:masterfrom
BestPig:feature/add-directory_name
Open

Add configurable DIRECTORY_NAME for rclone (Now compatible with S3 providers)#55
BestPig wants to merge 1 commit intoMiSTer-devel:masterfrom
BestPig:feature/add-directory_name

Conversation

@BestPig
Copy link

@BestPig BestPig commented Mar 9, 2021

For S3 provider, the destination bucket is not configurable in rclone.conf.
With old script, MiSTer is used as a bucket name.
With need a way to configure it, because Amazon S3 bucket are unique across all existing AWS bucket (not per user), and bucket name must be in lower case (event with self hosted solution like minio).

I replaced

MiSTer:MiSTer/$RCLONE_SD_DIR"

with

MiSTer:$DIRECTORY_NAME/$RCLONE_SD_DIR"

And made DIRECTORY_NAME configurable in a rclone.ini, if not exists, the default value MiSTer is used.
So no breaking change.
The update also include a documentation update to explain how to define this value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant