Add configurable DIRECTORY_NAME for rclone (Now compatible with S3 providers)#55
Open
BestPig wants to merge 1 commit intoMiSTer-devel:masterfrom
Open
Add configurable DIRECTORY_NAME for rclone (Now compatible with S3 providers)#55BestPig wants to merge 1 commit intoMiSTer-devel:masterfrom
BestPig wants to merge 1 commit intoMiSTer-devel:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For S3 provider, the destination bucket is not configurable in rclone.conf.
With old script,
MiSTeris used as a bucket name.With need a way to configure it, because Amazon S3 bucket are unique across all existing AWS bucket (not per user), and bucket name must be in lower case (event with self hosted solution like minio).
I replaced
with
And made DIRECTORY_NAME configurable in a rclone.ini, if not exists, the default value
MiSTeris used.So no breaking change.
The update also include a documentation update to explain how to define this value.