Feature/cnb exchange rate provider #803
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the provider into a real implementation by introducing a clear separation
between domain models and API responses. The provider is now injected via the .NET Generic Host using AddHttpClient,
which centralizes HTTP configuration (base address, timeout, headers) and improves maintainability.
Exchange rates are fetched asynchronously from the CNB daily endpoint, deserialized with System.Text.Json,
and normalized for currencies quoted per multiple units (rate divided by amount).
Finally, results are filtered to only include currencies requested by the caller from what the source provides.