Skip to content

Item updates and minimap framework#145

Merged
zarakava merged 7 commits intoMetroidAdvRandomizerSystem:mainfrom
zarakava:item-updates-and-minimap-framework
May 15, 2025
Merged

Item updates and minimap framework#145
zarakava merged 7 commits intoMetroidAdvRandomizerSystem:mainfrom
zarakava:item-updates-and-minimap-framework

Conversation

@zarakava
Copy link
Copy Markdown
Contributor

Adds new item locations and a framework for changing the base minimap.

@zarakava
Copy link
Copy Markdown
Contributor Author

test_new_items.json

Useful for testing

@cluekitty
Copy link
Copy Markdown
Contributor

test_new_items.json

Useful for testing

I attempted to use this test json and the patcher gave me an error for the room being read not matching the room with the minor location. the patcher was installed by pulling in your branch and running pip install -e . for an editable version of the install.

❯ python -m mars_patcher metroid4.gba test_new_items.gba ~/git/github/mars-fusion-asm/obj/test_new_items.json
Randomizing palettes...
Writing item assignments...
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/mnt/c/Users/<snip>/git/github/mars-patcher-py/src/mars_patcher/__main__.py", line 4, in <module>
    cli.main()
    ~~~~~~~~^^
  File "/mnt/c/Users/<snip>/git/github/mars-patcher-py/src/mars_patcher/cli.py", line 18, in main
    patch(
    ~~~~~^
        args.rom_path,
        ^^^^^^^^^^^^^^
    ...<2 lines>...
        lambda message, progress: print(message),
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/mnt/c/Users/<snip>/git/github/mars-patcher-py/src/mars_patcher/patcher.py", line 94, in patch
    item_patcher.write_items()
    ~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/mnt/c/Users/<snip>/git/github/mars-patcher-py/src/mars_patcher/item_patcher.py", line 129, in write_items
    assert read_room == min_loc.room, (
           ^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: room was '47', but was expected to be 46

@zarakava zarakava merged commit 34b15d6 into MetroidAdvRandomizerSystem:main May 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants