edit minimap tiles in DLR#133
Merged
biosp4rk merged 5 commits intoMetroidAdvRandomizerSystem:mainfrom Mar 14, 2025
Merged
Conversation
Contributor
Author
|
went back and made my code somewhat less awful |
biosp4rk
reviewed
Mar 10, 2025
biosp4rk
reviewed
Mar 10, 2025
biosp4rk
reviewed
Mar 10, 2025
Collaborator
|
All of your code comments are lowercase, but this repo uses sentence casing |
Collaborator
|
Things I can take care of:
|
Contributor
Author
|
updated with the requested changes as well as a fix for my alg trying to flip tiles with asymmetric contents such as nav stations |
Collaborator
|
mypy errors: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #132

It's not perfect, since there are still some tiles missing in vanilla, but the vast majority of tiles do in fact exist so it's still a pretty major improvement.
It'd probably be best to wait until MetroidAdvRandomizerSystem/mars-fusion-asm#217 is available before this goes through
p.s. im sorry for the code quality have fun reviewing 🫶