Merged
Conversation
Miepee
reviewed
Feb 13, 2025
| if lang in messages.item_messages | ||
| else messages.item_messages[Language.ENGLISH] | ||
| ), | ||
| centered=messages.centered, |
Contributor
There was a problem hiding this comment.
why isnt this just messages.centered?
Also pretty sure this should be messages.get("Centered", False)
Contributor
There was a problem hiding this comment.
this hasn't been addressed yet fwiw.
Collaborator
Author
There was a problem hiding this comment.
- Because the positional argument there is max_width, which is excluded
- I accidentally set the default to false in the schema, which is fixed now
Contributor
There was a problem hiding this comment.
i was mixing stuff up for both, oops.
Miepee
reviewed
Feb 13, 2025
Miepee
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.