fix: file import order#275
Merged
zarakava merged 1 commit intoMetroidAdvRandomizerSystem:mainfrom Jun 19, 2025
Merged
Conversation
…s causes major patch file differences with unhidden-maps
zarakava
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression where importing unhidden-pillars before unhidden-maps causes major patch file differences with unhidden-maps. These differences can include pointers to stored data which would differ after applying an unhidden map patch, causing the patcher to patch data which is no longer accurate once MetroidAdvRandomizerSystem/mars-patcher-py#154 has merged.
Screenshot shows file differences beyond what is intentional.
53e9cd4 is the current
mainHEAD, 9f48e44 ismainbefore #272 was merged