Skip to content

Issue #46: Refined exception messages for confidentiality and integrity algorithms #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NassimBtk merged 1 commit into from
Feb 11, 2025
Merged

Issue #46: Refined exception messages for confidentiality and integrity algorithms #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/org/sentrysoftware/ipmi/core/coding/security/CipherSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ public IntegrityAlgorithm getIntegrityAlgorithm() {
return instantiateIntegrityAlgorithm(IntegrityHmacSha1_96::new);
case SecurityConstants.IA_MD5_128:
// TODO: MD5-128
throw new IllegalArgumentException("Integrity algorithm MD5-128 is not yet implemented.");
case SecurityConstants.IA_HMAC_MD5_128:
return instantiateIntegrityAlgorithm(IntegrityHmacMd5_128::new);
case SecurityConstants.IA_HMAC_SHA256_128:
Expand Down Expand Up @@ -156,10 +157,10 @@ public ConfidentialityAlgorithm getConfidentialityAlgorithm() {
return ca;
case SecurityConstants.CA_XRC4_40:
// TODO: XRc4-40
throw new IllegalArgumentException(NOT_YET_IMPLEMENTED_MESSAGE);
throw new IllegalArgumentException("Confidentiality algorithm XRC4-40 is not yet implemented.");
case SecurityConstants.CA_XRC4_128:
// TODO: XRc4-128
throw new IllegalArgumentException(NOT_YET_IMPLEMENTED_MESSAGE);
throw new IllegalArgumentException("Confidentiality algorithm XRC4-128 is not yet implemented.");
default:
throw new IllegalArgumentException(
"Invalid confidentiality algorithm.");
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/sentrysoftware/ipmi/core/coding/security/IntegrityAlgorithm.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public byte[] generateAuthCode(final byte[] base) {
final byte[] result = new byte[authCodeLength];
byte[] updatedBase;

if (base[base.length - 2] == 0) { // pas de padding
if (base[base.length - 2] == 0) { // No padding
updatedBase = injectIntegrityPad(base, authCodeLength);
} else {
updatedBase = base;
Expand Down