Conversation
* Updated IpmiClientConfiguration, AuthenticationAlgorithm, CipherSuite and ConfidentialityAlgorithm * Added AuthenticationRakpHmacMd5, AuthenticationRakpHmacSha256, IntegrityHmacMd5_128, IntegrityHmacSha256_128
* Updated IntegrityHmacMd5_128, IntegrityHmacSha1_96 and IntegrityHmacSha256_128
NassimBtk
requested changes
Feb 5, 2025
src/main/java/org/sentrysoftware/ipmi/core/coding/security/AuthenticationRakpHmacMd5.java
Outdated
Show resolved
Hide resolved
src/main/java/org/sentrysoftware/ipmi/core/coding/security/AuthenticationRakpHmacMd5.java
Outdated
Show resolved
Hide resolved
src/main/java/org/sentrysoftware/ipmi/core/coding/security/IntegrityHmacMd5_128.java
Outdated
Show resolved
Hide resolved
src/main/java/org/sentrysoftware/ipmi/core/coding/security/IntegrityHmacMd5_128.java
Outdated
Show resolved
Hide resolved
* Factorize the code for integrity and authentication algorithms * Updated ConfidentialityAesCbc128
* Updated IntegrityNone
NassimBtk
requested changes
Feb 7, 2025
Collaborator
NassimBtk
left a comment
NassimBtk
left a comment
There was a problem hiding this comment.
Some additional changes and we are good to go.
src/main/java/org/sentrysoftware/ipmi/core/coding/security/IntegrityAlgorithm.java
Outdated
Show resolved
Hide resolved
src/main/java/org/sentrysoftware/ipmi/core/coding/security/AuthenticationAlgorithm.java
Outdated
Show resolved
Hide resolved
src/main/java/org/sentrysoftware/ipmi/core/coding/security/AuthenticationAlgorithm.java
Outdated
Show resolved
Hide resolved
src/main/java/org/sentrysoftware/ipmi/core/coding/security/CipherSuite.java
Outdated
Show resolved
Hide resolved
| return instantiateIntegrityHmacSha196Algorithm(); | ||
| case SecurityConstants.IA_MD5_128: | ||
| // TODO: MD5-128 | ||
| throw new IllegalArgumentException(NOT_YET_IMPLEMENTED_MESSAGE); |
Collaborator
There was a problem hiding this comment.
Is IntegrityHmacMd5_128.java responsible for handling both IA_MD5_128 and IA_HMAC_MD5_128?
Contributor
Author
There was a problem hiding this comment.
No, IntegrityHmacMd5_128 only handles IA_HMAC_MD5_128, not IA_MD5_128
src/main/java/org/sentrysoftware/ipmi/core/coding/security/IntegrityAlgorithm.java
Outdated
Show resolved
Hide resolved
* Updated CipherSuite, ConfidentialityAesCbc128, AuthenticationRakpNone, AuthenticatioRakpHmacSha1, IntegrityAlgorithm, AuthenticationAlgorithm, and IntegrityHmacSha1_96.
* Updated Connection.java
* remove unused imports
* Factorization before merge.
NassimBtk
approved these changes
Feb 7, 2025
NassimBtk
deleted the
feature/issue-46-add-support-for-sha-256-and-md5-authentication-algorithms
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added AuthenticationRakpHmacMd5, AuthenticationRakpHmacSha256, IntegrityHmacMd5_128, and IntegrityHmacSha256_128.
Updated CipherSuite, ConfidentialityAesCbc128, ConfidentialityAlgorithm, AuthenticationRakpNone, AuthenticatioRakpHmacSha1, IntegrityAlgorithm, AuthenticationAlgorithm, and IntegrityHmacSha1_96.
Tested :
HmacSH256 :
HmacMd5 :