Merged
Conversation
6f27530 to
0c4fe8c
Compare
bangyro
reviewed
Feb 11, 2026
bangyro
reviewed
Feb 11, 2026
675bc71 to
eacd7a9
Compare
bangyro
reviewed
Feb 12, 2026
bangyro
reviewed
Feb 12, 2026
bangyro
reviewed
Feb 12, 2026
codewithgun
reviewed
Feb 12, 2026
codewithgun
reviewed
Feb 12, 2026
bangyro
reviewed
Feb 12, 2026
rust-sdk/src/tests/mod.rs
Outdated
| @@ -1,4 +1,5 @@ | |||
| pub mod test_calculate_init_sqrt_price; | |||
| pub mod test_calculate_compounding_liquidity; | |||
| pub mod test_calculate_concenstrated_initial_sqrt_price; | |||
Collaborator
There was a problem hiding this comment.
typo in the file name. should be concenstrated -> concentrated
bangyro
approved these changes
Feb 12, 2026
Collaborator
bangyro
left a comment
There was a problem hiding this comment.
minor comment. rest looks good.
bangyro
reviewed
Feb 12, 2026
| // => s ^ 2 + s * (-pa + x * y) - y = 0 | ||
| // s = [(pa - xy) + √((xy - pa)² + 4y)]/2, // pa: min_sqrt_price, pb: max_sqrt_price | ||
| // s = [(pa - b << 128 / a / pb) + sqrt((b << 128 / a / pb - pa)² + 4 * b << 128 / a)] / 2 | ||
| pub fn calculate_concenstrated_initial_sqrt_price( |
Collaborator
There was a problem hiding this comment.
typo should be concenstrated -> concentrated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.