-
Notifications
You must be signed in to change notification settings - Fork 2
Enhance testing and plotting scripts #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @pirmink, why are these changes related to ICON and ensembles needed for this flexpart running with IFS inputs? |
Ok, I understand. This folder is cloned in flexpart-cosmo-icon for testing. |
| if [[ -n $ensemble ]] ; then | ||
| preset=opr/icon-ch2-eps/all_* | ||
| else | ||
| preset=opr/icon-ch1-ctrl/all_* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ICON-CH2 CTRL is not used when resol is i2 and not ensemble?
| preset=opr/icon-ch1-ctrl/all_* | |
| preset=opr/icon-ch2-ctrl/all_* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
icon-ch2-ctrl (one run, no ensemble) is not an operational set-up, so this prefix does not exist in pyflexplot. To test single member icon-ch2 outputs, the preset for the icon-ch1 control is used as workaround.
|
|
||
| # Determine executable | ||
| if [[ -n $operational ]] ; then | ||
| if [[ -z $operational ]] ; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
test_meteoswiss/plot_output
Outdated
| for infile in ${infiles[*]} ; do | ||
| echo $tag: "Submitting job to plot: ${infile}" | ||
| [[ -z $ensemble ]] && echo $tag: "Submitting job to plot: ${infile}" | ||
| cleanup_plot_dir $plot_dir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it normal that there's $plot_dir and $plotdir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's indeed an error. Good catch, thanks!
test_meteoswiss/test-fp
Outdated
| (( $# > 1 )) && shift && member="$1" | ||
| fi | ||
| ;; | ||
| -m | --min-dt-tl*) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m is reused here, -m is already used for --member
| -m | --min-dt-tl*) | |
| --min-dt-tl*) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, will correct this one
No description provided.