Skip to content

Conversation

@pirmink
Copy link
Collaborator

@pirmink pirmink commented Jan 7, 2026

No description provided.

@pirmink pirmink self-assigned this Jan 7, 2026
@ninaburg ninaburg self-requested a review January 8, 2026 08:04
@ninaburg
Copy link
Collaborator

ninaburg commented Jan 8, 2026

Hi @pirmink, why are these changes related to ICON and ensembles needed for this flexpart running with IFS inputs?

@ninaburg
Copy link
Collaborator

ninaburg commented Jan 8, 2026

Hi @pirmink, why are these changes related to ICON and ensembles needed for this flexpart running with IFS inputs?

Ok, I understand. This folder is cloned in flexpart-cosmo-icon for testing.

if [[ -n $ensemble ]] ; then
preset=opr/icon-ch2-eps/all_*
else
preset=opr/icon-ch1-ctrl/all_*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ICON-CH2 CTRL is not used when resol is i2 and not ensemble?

Suggested change
preset=opr/icon-ch1-ctrl/all_*
preset=opr/icon-ch2-ctrl/all_*

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon-ch2-ctrl (one run, no ensemble) is not an operational set-up, so this prefix does not exist in pyflexplot. To test single member icon-ch2 outputs, the preset for the icon-ch1 control is used as workaround.


# Determine executable
if [[ -n $operational ]] ; then
if [[ -z $operational ]] ; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

for infile in ${infiles[*]} ; do
echo $tag: "Submitting job to plot: ${infile}"
[[ -z $ensemble ]] && echo $tag: "Submitting job to plot: ${infile}"
cleanup_plot_dir $plot_dir
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it normal that there's $plot_dir and $plotdir?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's indeed an error. Good catch, thanks!

(( $# > 1 )) && shift && member="$1"
fi
;;
-m | --min-dt-tl*)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m is reused here, -m is already used for --member

Suggested change
-m | --min-dt-tl*)
--min-dt-tl*)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, will correct this one

@pirmink pirmink merged commit eec69a0 into main Jan 8, 2026
@pirmink pirmink deleted the fix_nl_adaption branch January 8, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants