This repository was archived by the owner on Feb 27, 2020. It is now read-only.
[Reviewer Rob] Add support for akakeys keyword on recv #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
There was a problem hiding this comment.
Should this be ("ik", "ik")? (The *what param is only used in error messages, it seems, but they should still be accurate.)
|
One comment, otherwise fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rob
As discussed, can you review my changes to SIPP to add support for extracting the ck and ik keys from an AKA authentication challenge. This adds an akakeys="<...>" parameter to the recv control which should be supplied on the recv control which catches the 401 response (in the same way auth="true" is set). The parameter is either an authentication block as can be supplied when building the response, or a reference to a field in a CSV file with an authentication block.
Sorry about the extra whitespace changes in the diff - my editor seems to insist on stripping trailing white space!
Mike