Skip to content

Unify consumer notebooks representation #4126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncarazon merged 1 commit into from
Jan 22, 2026
Merged

Unify consumer notebooks representation #4126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion front_end/src/app/(main)/questions/[id]/components/question_layout/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ const QuestionLayout: React.FC<PropsWithChildren<Props>> = ({
return (
<QuestionLayoutProvider>
<QuestionVariantComposer
postData={postData}
consumer={
<ConsumerQuestionLayout
postData={postData}
Expand Down
2 changes: 0 additions & 2 deletions front_end/src/app/(main)/questions/[id]/components/question_layout/question_info.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ const QuestionInfo: React.FC<Props> = ({
)}

<QuestionVariantComposer
postData={postData}
forecaster={<PostScoreData post={postData} />}
consumer={
<div className="hidden sm:block">
Expand All @@ -65,7 +64,6 @@ const QuestionInfo: React.FC<Props> = ({
<BackgroundInfo post={postData} />

<QuestionVariantComposer
postData={postData}
consumer={
isGroupOfQuestionsPost(postData) &&
postData.group_of_questions.graph_type ===
Expand Down
9 changes: 1 addition & 8 deletions front_end/src/app/(main)/questions/[id]/components/question_variant_composer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,12 @@ import { useFeatureFlagVariantKey } from "posthog-js/react";
import { ReactNode } from "react";

import { useAuth } from "@/contexts/auth_context";
import { PostWithForecasts } from "@/types/post";
import { CurrentUser, InterfaceType } from "@/types/users";
import { isConditionalPost, isNotebookPost } from "@/utils/questions/helpers";

type Variant = "forecaster" | "consumer";
const FLAG_KEY = "logged_out_question_view_variant";

export type QuestionVariantComposerProps = {
postData: PostWithForecasts;
consumer: ReactNode;
forecaster: ReactNode;
};
Expand All @@ -26,7 +23,6 @@ function getVariantFromUser(user: CurrentUser | null): Variant | null {
}

export const QuestionVariantComposer = ({
postData,
consumer,
forecaster,
}: QuestionVariantComposerProps) => {
Expand All @@ -38,10 +34,7 @@ export const QuestionVariantComposer = ({
return <>{forcedByUser === "consumer" ? consumer : forecaster}</>;
}

const isEligibleLoggedOut =
isNil(user) && !isNotebookPost(postData) && !isConditionalPost(postData);

if (isEligibleLoggedOut) {
if (isNil(user)) {
const v = flagVariant === "forecaster" ? "forecaster" : "consumer";
return <>{v === "consumer" ? consumer : forecaster}</>;
}
Expand Down
1 change: 0 additions & 1 deletion front_end/src/app/(main)/questions/[id]/components/question_view/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ const QuestionView: React.FC<Props> = ({
}) => {
return (
<QuestionVariantComposer
postData={postData}
consumer={<ConsumerQuestionView postData={postData} />}
forecaster={
<ForecasterQuestionView
Expand Down
1 change: 0 additions & 1 deletion front_end/src/components/posts_feed/paginated_feed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ const PaginatedPostsFeed: FC<Props> = ({

return (
<QuestionVariantComposer
postData={post}
consumer={
<ConsumerPostCard
post={post}
Expand Down
Loading