-
Notifications
You must be signed in to change notification settings - Fork 27
fix: show tooltip during hidden periods for multiple choice questions #4115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…tiple choice questions During hidden periods (when cpRevealsOn or isEmpty is true), the multiple choice timeline tooltip now properly displays: - User predictions if available, or "?" placeholder if not - Community prediction placeholders (CPRevealTime or "noForecastsYet") - The "me" column is always shown during hidden periods Also hides the forecasters count footer during hidden periods since this metric is not meaningful when community predictions are hidden. Fixes #4112 Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
|
@claude the number of forecasters should be shown during the hidden period. |
📝 WalkthroughWalkthroughRefines tooltip rendering in the multiple choices chart view: expands the tooltip active condition to include user choices and forecast availability flags, introduces a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (2)
✏️ Tip: You can disable this entire section by setting Comment |
|
Claude finished @SylvainChevalier's task in 53s —— View job Task Complete ✓Task: Show the number of forecasters during the hidden period Todo List:
SummaryI've updated the code to show the forecasters count during hidden periods. The change was made in What changed:
The forecasters count will now be visible in the tooltip during hidden periods ( | |
- Remove conditions hiding forecasters count during cpRevealsOn and isEmpty states - Forecasters count now displays consistently regardless of forecast availability Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
|
@claude the fix does not work, the tooltip still does not appear on hover during the hidden period. |
|
Claude finished @SylvainChevalier's task in 2m 16s —— View job Task Complete ✓Task: Fix tooltip not appearing on hover during hidden periods Todo List:
SolutionModified the tooltip rendering condition in What changed:
Previous behavior: Tooltip would only show if New behavior: During hidden periods, the tooltip will appear showing:
This ensures users can always see their own predictions and understand the hidden period status when hovering over the chart. |
…mpty Allow tooltip to render during hidden periods (cpRevealsOn or isEmpty) even if tooltipChoices array is empty. This ensures users see placeholder text and their own predictions during hidden periods. The tooltip now appears when any of these conditions are met: - tooltipChoices has items - tooltipUserChoices has items - forecast availability indicates a hidden period Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
Summary
Fixed the missing tooltip issue for multiple choice timeline charts during hidden periods.
Changes
cpRevealsOnorisEmpty)Testing
Fixes #4112
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
New Features
✏️ Tip: You can customize this high-level summary in your review settings.