Skip to content

fix: Enable forecast checkbox for multiple choice questions #4056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SylvainChevalier wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Enable forecast checkbox for multiple choice questions #4056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion front_end/src/components/comment_feed/comment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,6 @@ const Comment: FC<CommentProps> = ({

const canIncludeForecastInReply = useMemo(() => {
if (!postData?.question) return false;
if (postData.question.type === QuestionType.MultipleChoice) return false;
const latest = postData.question.my_forecasts?.latest;
return !!latest && isForecastActive(latest);
}, [postData]);
Expand Down
5 changes: 1 addition & 4 deletions front_end/src/components/comment_feed/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,8 @@ function shouldIncludeForecast(postData: PostWithForecasts | undefined) {
return false;
}

// we can link forecast only for date, binary and numeric questions
// we can link forecast for all question types
if (postData.question) {
if (postData.question.type === QuestionType.MultipleChoice) {
return false;
}
const latest = postData.question.my_forecasts?.latest;
return !!latest && isForecastActive(latest);
}
Expand Down
Loading