Merged
Conversation
MajorLift
reviewed
Aug 26, 2025
cryptodev-2s
previously approved these changes
Aug 26, 2025
Contributor
cryptodev-2s
left a comment
cryptodev-2s
left a comment
There was a problem hiding this comment.
LGTM! Just left one minor suggestion.
Co-authored-by: cryptodev-2s <109512101+cryptodev-2s@users.noreply.github.com>
MajorLift
reviewed
Aug 26, 2025
MajorLift
reviewed
Aug 26, 2025
CHANGELOG.md
Outdated
Comment on lines
+15
to
+18
|
|
||
| ### Changed | ||
|
|
||
| - Add `@types/lodash` as dependency ([#257](https://github.com/MetaMask/utils/pull/257)) |
Contributor
There was a problem hiding this comment.
I believe these may have been left unintentionally
Suggested change
| ### Changed | |
| - Add `@types/lodash` as dependency ([#257](https://github.com/MetaMask/utils/pull/257)) |
Contributor
There was a problem hiding this comment.
I'm a bit fuzzy on this, but the combined entry should still go under Changed, right?
It is important to remember that consumers care about capabilities first and interfaces second, so these would not count as an addition:
Adding a new dependency ❌
-- https://github.com/MetaMask/core/blob/main/docs/reviewing-release-prs.md#additions
MajorLift
reviewed
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the release candidate for version 11.5.0.