feat: Add KnownCaipNamespacedChainId type#258
Merged
Conversation
7 tasks
FrederikBolding
approved these changes
Aug 25, 2025
Contributor
I'll defer to @ccharly for final say here, but I think this is a useful addition. That being said, I think the reasoning (and the jsdoc comment) may need to be adjusted. /**
* A CAIP-2 chain ID that is guaranteed to have a known CAIP namespace
* (see {@link KnownCaipNamespace}).
*
* This is a narrower, more type-safe alternative to {@link CaipChainId} for use cases
* where the chain namespace must be one of the known standards.
*/ |
Co-authored-by: Eric Wolff <erwolff@gmail.com>
Contributor
Author
erwolff
approved these changes
Aug 25, 2025
Contributor
|
Sorry, completely miss the notification here. But that sounds like a good addition to me yes! Thanks 💪 |
MajorLift
added a commit
that referenced
this pull request
Aug 28, 2025
…eter (#262) This commit refactors `KnownCaipNamespacedChainId` (introduced in [#258](#258)) into a generic type by adding a `Namespace` type parameter. This allows the type to be narrowed down to chain IDs with a specific namespace. This is not a breaking change, as `Namespace` defaults to a type union of known CAIP namespaces. The type's previous behavior is preserved when its generic type parameter is omitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a type for CAIP chain IDs that are namespaced by a known CAIP namespace.
This type enables the usage of safer literal string types for namespaced CAIP chain IDs, and is intended as a narrower alternative to
CaipChainId.Any and all suggestions about type name, jsdoc comments etc. are welcome.