Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jan 9, 2026

Discovered while investigating a memory leak, does not seem to be a direct fix though we should be destroying all streams that are piped.


Note

Ensures the multiplexed stream is properly tracked and destroyed during snap termination.

  • Extends JobStreams to include mux: ObjectMultiplex and renames _connection to connection
  • Returns mux and connection from #initStreams and includes them in job.streams so termination destroys them with other streams

Written by Cursor Bugbot for commit 4fa79ec. This will update automatically on new commits. Configure here.

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.34%. Comparing base (4aaa4c3) to head (4fa79ec).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3795   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         422      422           
  Lines       12059    12059           
  Branches     1872     1872           
=======================================
  Hits        11859    11859           
  Misses        200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding marked this pull request as ready for review January 9, 2026 14:16
@FrederikBolding FrederikBolding requested a review from a team as a code owner January 9, 2026 14:16
@FrederikBolding FrederikBolding added this pull request to the merge queue Jan 9, 2026
Merged via the queue into main with commit 36e9189 Jan 9, 2026
127 checks passed
@FrederikBolding FrederikBolding deleted the fb/destroy-mux branch January 9, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants