fix: Ensure multiplex is destroyed #3795
Merged
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while investigating a memory leak, does not seem to be a direct fix though we should be destroying all streams that are piped.
Note
Ensures the multiplexed stream is properly tracked and destroyed during snap termination.
JobStreamsto includemux: ObjectMultiplexand renames_connectiontoconnectionmuxandconnectionfrom#initStreamsand includes them injob.streamsso termination destroys them with other streamsWritten by Cursor Bugbot for commit 4fa79ec. This will update automatically on new commits. Configure here.