chore: tron snap code quality improvements#212
Open
ulissesferreira wants to merge 1 commit intomainfrom
Open
Conversation
e9fb3ee to
3949ebc
Compare
e0c3b18 to
5835933
Compare
- Remove entities barrel file and use direct imports for clarity - Add limit parameter to TrongridApiClient.getTransactionInfoByAddress - Add lightweight checkAddressActivity method for account discovery - Use checkAddressActivity in discoverAccounts instead of full tx fetch - Fix cursor handling in listAccountTransactions for missing cursors - Move account sync earlier in trackTransaction for reliability - Remove unused params from setSelectedAccounts background event - Narrow findByIds return type from nullable to empty array - Narrow synchronize* method params to TronKeyringAccount - Remove unnecessary type cast in TransactionsMapper call Co-authored-by: Cursor <cursoragent@cursor.com>
5835933 to
73e1b2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
entities/index.tsbarrel file and use direct module imports for better clarity and tree-shakinglimitparameter toTrongridApiClient.getTransactionInfoByAddressto support lightweight queriescheckAddressActivitymethod toTransactionsServicefor efficient account discovery (queries withlimit=1instead of downloading full transaction history)checkAddressActivityindiscoverAccountsinstead offetchNewTransactionsForAccountlistAccountTransactions— return empty results when cursor is not found instead of starting from index-1trackTransactionso it still runs even if the sender account lookup failsparams: { accountIds }fromsetSelectedAccountsbackground event callfindByIdsreturn type fromTronKeyringAccount[] | nulltoTronKeyringAccount[](removing impossible null)synchronize*method parameters fromKeyringAccounttoTronKeyringAccountaccount as TronKeyringAccountinTransactionsMappercallTest plan
checkAddressActivitytests cover true/false/error casesdiscoverAccountstests use the newcheckAddressActivitymockMade with Cursor