Conversation
…te and validation
…ermissions method
… existing permissions tests
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/gator-permissions-snap/src/core/existingpermissions/existingPermissionsService.ts
Show resolved
Hide resolved
jeffsmale90
left a comment
jeffsmale90
left a comment
There was a problem hiding this comment.
Looking good! I think we don't need to memoize rn - wdyt?
| permissionData: permissionRequest.permission.data, | ||
| }); | ||
|
|
||
| // Validate the permission request early, before showing any UI |
packages/gator-permissions-snap/src/core/existingpermissions/permissionFormatter.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| } catch { | ||
| // If formatting fails, dialog still shows with skeleton | ||
| // This is acceptable - user can still interact with the dialog | ||
| } |
There was a problem hiding this comment.
Formatting failure permanently shows disabled skeleton button
Medium Severity
If the try block (formatting or dialogInterface.show(actualContent)) throws, the catch silently swallows the error and leaves the skeleton UI visible. The skeleton's confirm button has disabled={true}, so even though the handler is registered afterward at line 167, the user can never click it. The user is stuck on a permanent loading state with no error feedback — only able to dismiss via the X button. The comment "user can still interact with the dialog" is misleading since the only possible interaction is cancellation.
Additional Locations (1)
2 participants
Description
This PR enhances the existing permissions page to provide a better user experience and increase transparency. It implements three key improvements:
Multi-chain Permission Display: Shows all chains granted to an origin, not just the requested chain. Users now see the full picture of their existing permissions across all networks.
Account Grouping: Existing permissions are grouped by account address (CAIP-10 format) for better organization and clarity.
Loading State with Skeleton UI: Adds a skeleton/loading state while permissions are being formatted. The dialog shows placeholder content immediately and updates with real data once formatting completes, providing visual feedback to users during loading.
Permission Validation: Validates permissions before display to ensure data integrity. Invalid or malformed permissions are filtered out before rendering.
Additionally, permission request validation now occurs earlier in the request lifecycle (before showing existing permissions dialog) to catch invalid requests immediately.
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2026-03-12.at.1.17.03.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches permission-request flow and existing-permissions rendering, including earlier request validation and changing which stored permissions are surfaced (now all chains for an origin). Also adds caching to
TokenMetadataService, which can affect display correctness if cache keys/invalidations are wrong.Overview
Improves the existing permissions dialog by showing an immediate skeleton state (
buildExistingPermissionsSkeletonContent) and then swapping in the fully formatted content once token metadata formatting completes.Changes existing-permissions lookup to return all non-revoked permissions for a given origin across all chains (instead of filtering by requested
chainId), filters out malformed stored permissions before rendering, and adjusts grouping/display to key byfromaddress (Hex) plus UTC rendering for streamstartTime.Adds
TokenMetadataService.getTokenMetadata()with an in-memory per-chainId/asset cache and updates permission formatting to use cached metadata and format bothmaxAmountandperiodAmount. Includes new/expanded Jest coverage forExistingPermissionsServiceand token metadata caching.Written by Cursor Bugbot for commit 72a6533. This will update automatically on new commits. Configure here.