Improve clarity of justification field in Permission Picker#282
Open
jeffsmale90 wants to merge 2 commits intomainfrom
Open
Improve clarity of justification field in Permission Picker#282jeffsmale90 wants to merge 2 commits intomainfrom
jeffsmale90 wants to merge 2 commits intomainfrom
Conversation
- Change label from 'Reason' to 'Justification' - Increase max length from 120 to 300 - Increase max length that will be shown without ellipsis from 20 to 165 - Stack components vertically to reduce whitespace
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Co-authored-by: jeffsmale90 <jeffsmale90@users.noreply.github.com>
mj-kiwi
approved these changes
Mar 12, 2026
mj-kiwi
approved these changes
Mar 12, 2026
| @@ -20,10 +20,10 @@ | |||
| "message": "The token being requested" | |||
| }, | |||
| "reasonLabel": { | |||
Contributor
There was a problem hiding this comment.
maybe rename this key to justificationLabel should be better
| "message": "Reason" | ||
| "message": "Justification" | ||
| }, | ||
| "reasonTooltip": { |
Contributor
There was a problem hiding this comment.
Same here. Renaming this key to justificationTooltip would avoid confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI/i18n and validation-limit updates; main risk is minor layout regressions or unexpected truncation/validation behavior for edge-length justifications.
Overview
Improves the permission request justification UX by renaming the field label/tooltip from Reason to Justification and stacking the label and text vertically in
permissionHandlerContent.Increases allowed justification length from
120to300characters in the sharedzSanitizedJustificationschema, and increases theShowMoreTexttruncation threshold from20to165characters (always vertical layout). Updates Jest snapshots and schema boundary tests to match the new copy, layout, and limits.Written by Cursor Bugbot for commit 5f01f28. This will update automatically on new commits. Configure here.