-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: Add patch to mitigate persistence issues impacting Snaps #23973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
48002cb to
dec8cce
Compare
andrepimenta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThis PR involves dependency updates to multiple MetaMask controller packages: Key Changes:
Risk Assessment:
Test Coverage Rationale:
The snaps-related changes are important but preinstalled snaps are used by the wallet platform for features like Bitcoin/Solana/Tron support, so they're covered by the wallet platform tests. The permission sync fix is defensive and should not break existing functionality. |
|



Description
Patch to bring in the changes from: #23976 / MetaMask/snaps#3775 to the RC, which fixes a production issue preventing Snaps from executing properly due to a persistence bug. The patch was created by building the main Snaps branch locally and copying over the SnapController files.
Note
Switches @metamask/snaps-controllers to a Yarn patch and updates yarn.lock accordingly.
@metamask/snaps-controllers@17.0.0to a Yarn patch reference inpackage.json.yarn.lockto resolve the patched package (new entries/resolutions and checksums).Written by Cursor Bugbot for commit 8a44c10. This will update automatically on new commits. Configure here.