Skip to content

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Dec 12, 2025

Description

Patch to bring in the changes from: #23976 / MetaMask/snaps#3775 to the RC, which fixes a production issue preventing Snaps from executing properly due to a persistence bug. The patch was created by building the main Snaps branch locally and copying over the SnapController files.


Note

Switches @metamask/snaps-controllers to a Yarn patch and updates yarn.lock accordingly.

  • Dependencies:
    • Switch @metamask/snaps-controllers@17.0.0 to a Yarn patch reference in package.json.
    • Update yarn.lock to resolve the patched package (new entries/resolutions and checksums).

Written by Cursor Bugbot for commit 8a44c10. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-core-platform Core Platform team label Dec 12, 2025
@FrederikBolding FrederikBolding marked this pull request as ready for review December 12, 2025 14:53
@FrederikBolding FrederikBolding requested a review from a team as a code owner December 12, 2025 14:53
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeCore, SmokeWalletPlatform, SmokeTrade
  • Risk Level: medium
  • AI Confidence: 75%
click to see 🤖 AI reasoning details

This PR involves dependency updates to multiple MetaMask controller packages:

Key Changes:

  1. @metamask/snaps-controllers (17.0.0 - with patch): A significant patch was added that ensures preinstalled Snaps have their expected permissions. The patch adds logic to automatically restore permissions for preinstalled snaps if they're out of sync, which is a critical fix.

  2. Multiple Controller Updates:

    • @metamask/transaction-controller: 62.3.0 → 62.6.0
    • @metamask/network-controller: 25.0.0 → 27.0.0 (2 major versions)
    • @metamask/controller-utils: 11.11.0 → 11.16.0
    • @metamask/eth-json-rpc-middleware: 21.0.0 → 22.0.0
    • @metamask/json-rpc-engine: 10.0.3 → 10.2.0
    • @metamask/smart-transactions-controller: 20.1.0 → 21.0.0
    • @metamask/bridge-controller: 61.0.0 (now with patch)
    • @metamask/transaction-pay-controller: 10.1.0 → 10.5.0
  3. New Dependency:

    • @metamask/profile-metrics-controller: 1.1.0 (new addition)
  4. Wallet Snap Updates:

    • @metamask/tron-wallet-snap: 1.13.0 → 1.16.0

Risk Assessment:

  • Medium Risk due to:
    • Multiple controller updates including network-controller (major version jump)
    • Critical fix in snaps-controllers for permission synchronization
    • Transaction controller updates that affect core wallet functionality
    • New bridge-controller patch

Test Coverage Rationale:

  • SmokeCore: Network controller and JSON-RPC changes affect core infrastructure
  • SmokeWalletPlatform: Transaction controller, network switching, and core wallet operations are all affected
  • SmokeTrade: Bridge controller and smart-transactions-controller updates affect DEX trading and token swaps

The snaps-related changes are important but preinstalled snaps are used by the wallet platform for features like Bitcoin/Solana/Tron support, so they're covered by the wallet platform tests. The permission sync fix is defensive and should not break existing functionality.

View GitHub Actions results

@joaoloureirop joaoloureirop added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Dec 12, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Dec 12, 2025
@sonarqubecloud
Copy link

@joaoloureirop joaoloureirop enabled auto-merge (squash) December 12, 2025 17:38
@joaoloureirop joaoloureirop merged commit 23fdbf1 into release/7.61.0 Dec 12, 2025
91 of 92 checks passed
@joaoloureirop joaoloureirop deleted the fb/snaps-rc-patch branch December 12, 2025 18:57
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-M team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants