Skip to content

chore: Update assets and accounts packages#12984

Merged
owencraston merged 14 commits intomainfrom
chore/update-assets-controller
Jan 16, 2025
Merged

chore: Update assets and accounts packages#12984
owencraston merged 14 commits intomainfrom
chore/update-assets-controller

Conversation

@owencraston
Copy link
Contributor

@owencraston owencraston commented Jan 14, 2025 •
edited
Loading

Description

The primary purpose of this PR is to update the accounts controller and the assets-controller to the latest version. In doing that, there were several other package updates that were needed. Here is a summary of the updates...

🔴 Major updates 🔴

"@metamask/accounts-controller": "^20.0.1" -> ^21.0.0

"@metamask/assets-controllers": "^45.1.1", -> ^46.0.0",

"@metamask/utils": "^10.0.1" -> ^11.0.1"

Added "@metamask/keyring-internal-api": "^2.0.0",

  • changelog
  • This package was a peer dep on the latest accounts controller and assets controller. Given this I figured we should add it now anyway.
  • Changes needed
    • update imports from @metamask/keyring-api to @metamask/keyring-internal-api
    • add support for scopes in the InternalAccount object
    • added migration (066.ts) to backfill the scopes to existing accounts.

Added @metamask/keyring-snap-client: "^2.0.0"

  • changelog
  • Added because KeyringClient is now exported from @metamask/keyring-snap-client instead of @metamask/keyring-api'. See app/components/Views/AddAccountActions/AddAccountActions.tsx for changes.

"@metamask/keyring-api": "^10.1.0", -> ^13.0.0"

"@metamask/eth-snap-keyring": "^5.0.1" -> ^7.0.0"

🟡 Minor updates 🟡

"@metamask/base-controller": "^7.0.1", -> ^7.1.1

  • changelog
  • Changes
    • Bump @metamask/utils from ^10.0.0 to ^11.0.1
    • Rename ControllerMessenger to Messenger (chore: Rename ControllerMessenger to Messenger core#5050)
      • ControllerMessenger has been renamed to Messenger
      • RestrictedControllerMessengerConstraint has been renamed to RestrictedMessengerConstraint
      • RestrictedControllerMessenger has been renamed to RestrictedMessenger
      • The RestrictedMessenger constructor parameter controllerMessenger has been renamed to messenger, though the old name is still accepted
      • The old names remain exported as deprecated aliases of the new names, so this is not a breaking change.

"@metamask/providers": "^18.1.0" -> ^18.3.1"

🟢 Patch updates 🟢

"@metamask/json-rpc-engine": "^10.0.0" -> ^10.0.2",

"@metamask/json-rpc-middleware-stream": "^8.0.2" -> 8.0.6"

"@metamask/rpc-errors": "^7.0.1" -> ^7.0.2"

Related issues

Fixes: #12967
Fixes: #12966

Fixes: https://github.com/MetaMask/accounts-planning/issues/758

Unblocks: #12599

Manual testing steps

Basic import account flow with tokens

Screen.Recording.2025-01-15.at.3.07.12.PM.mov

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-accounts-framework Accounts team label Jan 14, 2025
@socket-security
Copy link

socket-security bot commented Jan 14, 2025 •
edited
Loading

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/abi-utils@3.0.0 None 0 0 B
npm/@metamask/accounts-controller@21.0.0 🔁 npm/@metamask/accounts-controller@20.0.1 None +1 388 kB metamaskbot
npm/@metamask/assets-controllers@46.0.0 🔁 npm/@metamask/assets-controllers@45.1.1 None +1 2.63 MB metamaskbot
npm/@metamask/base-controller@7.1.1 🔁 npm/@metamask/base-controller@7.0.2 None 0 348 kB metamaskbot
npm/@metamask/controller-utils@11.4.5 🔁 npm/@metamask/controller-utils@11.4.4 None 0 266 kB metamaskbot
npm/@metamask/eth-sig-util@8.1.2 🔁 npm/@metamask/eth-sig-util@8.0.0 None 0 133 kB danfinlay, gudahtt, kumavis, ...6 more
npm/@metamask/eth-snap-keyring@8.0.0 🔁 npm/@metamask/eth-snap-keyring@5.0.1 None 0 338 kB metamaskbot
npm/@metamask/json-rpc-engine@10.0.2 🔁 npm/@metamask/json-rpc-engine@10.0.1 None 0 178 kB metamaskbot
npm/@metamask/json-rpc-middleware-stream@8.0.6 🔁 npm/@metamask/json-rpc-middleware-stream@8.0.5 None 0 50.3 kB metamaskbot
npm/@metamask/keyring-api@13.0.0 None 0 484 kB metamaskbot
npm/@metamask/keyring-internal-api@2.0.0 None 0 63.5 kB metamaskbot
npm/@metamask/keyring-internal-snap-client@2.0.0 None 0 32.2 kB metamaskbot
npm/@metamask/keyring-snap-client@2.0.0 None 0 59.2 kB metamaskbot
npm/@metamask/keyring-utils@1.0.0 None +1 776 kB metamaskbot
npm/@metamask/providers@18.3.1 🔁 npm/@metamask/providers@18.2.0 None +1 668 kB metamaskbot

View full report↗︎

@owencraston owencraston force-pushed the chore/update-assets-controller branch from 2c6d5d9 to d4e2d35 Compare January 15, 2025 00:45
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d4e2d35
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b6060aa0-2256-4f9b-9de5-4b9b5aefbad4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@owencraston owencraston force-pushed the chore/update-assets-controller branch from bd54717 to e739ac1 Compare January 15, 2025 19:00
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e739ac1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/31e98c9b-ea89-4403-ab32-3890c31584e7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@owencraston owencraston force-pushed the chore/update-assets-controller branch 2 times, most recently from 4e5e84a to 9253cf0 Compare January 15, 2025 20:04
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9253cf0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c3f7c500-3e0e-4177-bb6f-cea6c8ccc969

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 15, 2025
@owencraston owencraston force-pushed the chore/update-assets-controller branch 2 times, most recently from 14199d5 to 310cd82 Compare January 15, 2025 22:16
@owencraston owencraston marked this pull request as ready for review January 15, 2025 22:16
@owencraston owencraston requested review from a team as code owners January 15, 2025 22:16
@owencraston owencraston requested a review from a team January 15, 2025 22:16
@owencraston owencraston requested a review from a team as a code owner January 15, 2025 22:16
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 310cd82
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3b1a6044-3f3e-4f47-8c2b-d493a734f527

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@owencraston owencraston force-pushed the chore/update-assets-controller branch from 51a63b8 to 1829581 Compare January 16, 2025 17:59
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 1829581
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/83242050-764c-4b77-8700-ea154a26270f

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

vinnyhoward
vinnyhoward previously approved these changes Jan 16, 2025
View reviewed changes
tommasini
tommasini previously approved these changes Jan 16, 2025
View reviewed changes
@owencraston owencraston dismissed stale reviews from tommasini and vinnyhoward via 992798e January 16, 2025 18:32
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 992798e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8f866dbc-7861-4469-a4b1-3335ec64ec25

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 16, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
94.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@owencraston owencraston added this pull request to the merge queue Jan 16, 2025
pedronfigueiredo
pedronfigueiredo approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into main with commit 4c43298 Jan 16, 2025
41 of 42 checks passed
@owencraston owencraston deleted the chore/update-assets-controller branch January 16, 2025 19:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@sahar-fehri sahar-fehri sahar-fehri approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@tommasini tommasini tommasini approved these changes

@sleepytanya sleepytanya sleepytanya approved these changes

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-7.39.0 Issue or pull request that will be included in release 7.39.0 team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update metamask/assets-controllers to version 46.0.0 Update metamask/accounts-controller to version 21.0.0

9 participants

@owencraston @FrederikBolding @sahar-fehri @pedronfigueiredo @Prithpal-Sooriya @vinnyhoward @tommasini @sleepytanya @metamaskbot