Skip to content

FEAT: Update what's new and settings copy to communicate additional network coverage on extension#22618

Merged
segun merged 2 commits intodevelopfrom
olu/update-whats-new-settings-copy
Jan 24, 2024
Merged

FEAT: Update what's new and settings copy to communicate additional network coverage on extension#22618
segun merged 2 commits intodevelopfrom
olu/update-whats-new-settings-copy

Conversation

@segun
Copy link
Contributor

@segun segun commented Jan 22, 2024

Description

  • What's new copy should be updated to:

Steer clear of known scams while still preserving your privacy with security alerts powered by Blockaid. This feature is available on Arbitrum, Avalanche, BNB chain, Ethereum Mainnet, Linea, Optimism and Polygon.

Always do your own due diligence before approving requests.

  • Settings copy should be updated to:

Privacy preserving - no data is shared with third parties. Available on Arbitrum, Avalanche, BNB chain, Ethereum Mainnet, Linea, Optimism and Polygon.

Related issues

Fixes: #1695

Blocked By: #22070

Screenshots/Recordings

Before

before_copy_changes.mov

After

after_copy_changes.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@segun segun added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 22, 2024
@segun segun self-assigned this Jan 22, 2024
@segun segun requested a review from a team as a code owner January 22, 2024 14:29
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 22, 2024
jpuri
jpuri previously approved these changes Jan 22, 2024
@segun segun force-pushed the olu/update-whats-new-settings-copy branch from df5fd58 to ca84272 Compare January 23, 2024 07:44
@segun segun changed the title Update what's new and settings copy to communicate additional network coverage on extension FEAT: Update what's new and settings copy to communicate additional network coverage on extension Jan 23, 2024
@segun segun force-pushed the olu/update-whats-new-settings-copy branch from ef02431 to 821634a Compare January 24, 2024 11:51
@metamaskbot
Copy link
Collaborator

Builds ready [821634a]
Page Load Metrics (806 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint90147115189
domContentLoaded9301552
load67110328069646
domInteractive9301552
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -56 Bytes (-0.00%)

@codecov
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (978e57a) 68.12% compared to head (821634a) 68.12%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #22618   +/-   ##
========================================
  Coverage    68.12%   68.12%           
========================================
  Files         1087     1087           
  Lines        42663    42663           
  Branches     11349    11349           
========================================
  Hits         29064    29064           
  Misses       13599    13599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@segun segun merged commit 5e8b92c into develop Jan 24, 2024
@segun segun deleted the olu/update-whats-new-settings-copy branch January 24, 2024 14:45
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
@metamaskbot metamaskbot added the release-11.10.0 Issue or pull request that will be included in release 11.10.0 label Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.10.0 Issue or pull request that will be included in release 11.10.0 team-confirmations-secure-ux-PR PRs from the confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants