Skip to content

fix metaRPCClientFactory id handling#11116

Merged
shanejonas merged 2 commits intodevelopfrom
fix-metarpc-id-check
May 17, 2021
Merged

fix metaRPCClientFactory id handling#11116
shanejonas merged 2 commits intodevelopfrom
fix-metarpc-id-check

Conversation

@shanejonas
Copy link
Contributor

Explanation:
these changes affect null and undefined and 0 handling for metaRPC to reflect the JSON-RPC Spec

Rel: MetaMask/json-rpc-middleware-stream#18

@shanejonas shanejonas requested a review from a team as a code owner May 17, 2021 19:56
@shanejonas shanejonas requested a review from PeterYinusa May 17, 2021 19:56
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@shanejonas shanejonas force-pushed the fix-metarpc-id-check branch from 4af1078 to a860ac0 Compare May 17, 2021 20:06
@shanejonas shanejonas requested a review from rekmarks May 17, 2021 20:19
@metamaskbot
Copy link
Collaborator

Builds ready [a860ac0]
Page Load Metrics (637 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint449267136
domContentLoaded367114463514469
load368114563714469
domInteractive366114363414469

@metamaskbot
Copy link
Collaborator

Builds ready [87f30b2]
Page Load Metrics (668 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint4613268189
domContentLoaded43195166612058
load43295266812058
domInteractive43195166612058

Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shanejonas shanejonas merged commit abba7f4 into develop May 17, 2021
@shanejonas shanejonas deleted the fix-metarpc-id-check branch May 17, 2021 21:46
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants