chore(deps): bump @metamask/keyring-api to v0.2.1#70
Conversation
|
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @metamask/snaps-controllers@0.35.2-flask.1 |
| // @ts-expect-error Check https://github.com/ianstormtaylor/superstruct/issues/983 | ||
| params: { account: account as unknown as InternalAccount }, |
There was a problem hiding this comment.
At the moment we're suppressing this error until it's fixed in @metamask/utils.
Type 'undefined' is not assignable to type 'Json'.
There was a problem hiding this comment.
@gantunesr It should be fixed in @metamask/utils in 8.1.0: #69
| import { | ||
| EthMethod, | ||
| EthAccountType, | ||
| InternalAccount, | ||
| } from '@metamask/keyring-api'; |
There was a problem hiding this comment.
The tests regarding serialize and deserialize are not working currently because of the data type change.
There was a problem hiding this comment.
@danroc @montelaidev regarding our conversation earlier today, when should the metadata attribute be added to the accounts object to comply with the InternalAccount? And what's the source of data for the fields snap and name?
There was a problem hiding this comment.
snap metadata is filled by the SnapKeyring (this repo), the name should be filled by the AccountsController.
|
Merged into #75. |
3 participants
Resolves: https://github.com/MetaMask/accounts-planning/issues/43