Closed
Conversation
legobeat
suggested changes
Oct 16, 2024
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - Bypass numerical address cast ([#391](https://github.com/MetaMask/eth-sig-util/pull/391)) |
Contributor
There was a problem hiding this comment.
Suggested change
| - Bypass numerical address cast ([#391](https://github.com/MetaMask/eth-sig-util/pull/391)) | |
| - **BREAKING**: Values of type `number` are not accepted as address parameter anymore. Valid values are `string` and `Uint8Array`. ([#391](https://github.com/MetaMask/eth-sig-util/pull/391)) |
@OGPoyraz I think the change is breaking? The PR title also does not meaningfully explain the change for users. Please confirm if this is right.
Member
There was a problem hiding this comment.
You're right this message is not clear. The removed part on this PR is removing the cast of the numerical address, I've adjusted changelog.
I am a bit unsure that it should be a breaking change or not, what do you think?
Contributor
There was a problem hiding this comment.
I would say it's breaking because:
- There exists input that was previously interpreted as valid and handled, which will now break
- We can see example of this because of the need to remove these test cases: https://github.com/MetaMask/eth-sig-util/pull/391/files#diff-f6dbf9fbb07112db7776d1c764cea2d7e6df9d05cbdd800178d56ef5215a807bL4300-L4301
Member
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the release candidate for version 7.1.0.