Update `@metamask/json-rpc-engine` and `@metamask/utils` by Mrtenz · Pull Request #1724 · MetaMask/core

Mrtenz · 2023-09-26T10:44:04Z

Explanation

This bumps @metamask/json-rpc-engine (previously json-rpc-engine) and @metamask/utils to the latest versions. This is required to be able to use the latest versions of @metamask/json-rpc-engine and @metamask/eth-json-rpc-middleware in Snaps (MetaMask/snaps#1781).

The updated version of @metamask/json-rpc-engine is functionally equivalent to the previous version, but has improved types. To be able to bump it, it also required a bump of @metamask/utils.

Changelog

`@metamask/accounts-controller`

CHANGED: Bump @metamask/utils from ^6.2.0 to ^8.1.0

`@metamask/address-book-controller`

CHANGED: Bump @metamask/utils from ^6.2.0 to ^8.1.0

`@metamask/approval-controller`

CHANGED: Bump @metamask/utils from ^6.2.0 to ^8.1.0

`@metamask/assets-controller`

CHANGED: Bump @metamask/utils from ^6.2.0 to ^8.1.0

`@metamask/base-controller`

CHANGED: Bump @metamask/utils from ^6.2.0 to ^8.1.0

`@metamask/controller-utils`

CHANGED: Bump @metamask/utils from ^6.2.0 to ^8.1.0

`@metamask/ens-controller`

CHANGED: Bump @metamask/utils from ^6.2.0 to ^8.1.0

`@metamask/gas-fee-controller`

CHANGED: Bump @metamask/utils from ^6.2.0 to ^8.1.0

`@metamask/keyring-controller`

CHANGED: Bump @metamask/utils from ^6.2.0 to ^8.1.0

`@metamask/message-manager`

CHANGED: Bump @metamask/utils from ^6.2.0 to ^8.1.0

`@metamask/network-controller`

CHANGED: Bump @metamask/utils from ^6.2.0 to ^8.1.0

`@metamask/notification-controller`

CHANGED: Bump @metamask/utils from ^6.2.0 to ^8.1.0

`@metamask/permission-controller`

BREAKING: RestrictedMethodParameters no longer accepts void as type.
CHANGED: Bump @metamask/utils from ^6.2.0 to ^8.1.0
CHANGED: Bump @metamask/json-rpc-engine from ^6.1.0 to ^7.1.1

`@metamask/signature-controller`

CHANGED: Bump @metamask/utils from ^6.2.0 to ^8.1.0

`@metamask/transaction-controller`

CHANGED: Bump @metamask/utils from ^6.2.0 to ^8.1.0

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've highlighted breaking changes using the "BREAKING" category above as appropriate

Mrtenz · 2023-09-26T10:57:51Z

node_modules/@metamask/rpc-methods/dist/types/restricted/getLocale.d.ts(46,113): error TS2344: Type 'void' does not satisfy the constraint 'JsonRpcParams'.

~~Updating here requires @metamask/rpc-methods to be updated, but updating in @metamask/rpc-methods requires this to be updated... 😅~~

Solved this by patching @metamask/rpc-methods. We can remove the patch when that is updated.

Mrtenz · 2023-09-26T11:14:31Z

package.json

+    "@metamask/rpc-methods@^0.38.1-flask.1": "patch:@metamask/rpc-methods@npm%3A0.38.1-flask.1#./.yarn/patches/@metamask-rpc-methods-npm-0.38.1-flask.1-081e1eb5b3.patch",
+    "@metamask/rpc-methods@^1.0.1": "patch:@metamask/rpc-methods@npm%3A0.38.1-flask.1#./.yarn/patches/@metamask-rpc-methods-npm-0.38.1-flask.1-081e1eb5b3.patch"


@metamask/eth-snap-keyring and @metamask/keyring-api need to update the version of @metamask/snaps-controllers so we can dedupe this.

Mrtenz · 2023-09-26T11:38:17Z

Tests are failing because we're using eth-rpc-errors instead of @metamask/rpc-errors. Bumping this requires a bump in approval-controller, which is not possible, because:

TS2322: Type (value: Json | AddResult | PromiseLike<Json | AddResult>) => void is not assignable to type  ApprovalPromiseResolve

And that can't be solved without changing the exactOptionalPropertyTypes option.

legobeat · 2023-09-27T02:30:56Z

Tests are failing because we're using eth-rpc-errors instead of @metamask/rpc-errors. Bumping this requires a bump in approval-controller, which is not possible, because:
TS2322: Type (value: Json | AddResult | PromiseLike<Json | AddResult>) => void is not assignable to type  ApprovalPromiseResolve 
And that can't be solved without changing the exactOptionalPropertyTypes option.

Where do you see this error? Seems fine here:

Mrtenz · 2023-09-27T08:48:35Z

Tests are failing because we're using eth-rpc-errors instead of @metamask/rpc-errors. Bumping this requires a bump in approval-controller, which is not possible, because:
TS2322: Type (value: Json | AddResult | PromiseLike<Json | AddResult>) => void is not assignable to type  ApprovalPromiseResolve 
And that can't be solved without changing the exactOptionalPropertyTypes option.
Where do you see this error? Seems fine here:

Use @metamask/rpc-errors in approval-controller #1731

diff minus merge with main

I might've done something wrong then. 🤔 Thanks for looking into this!

legobeat · 2023-09-29T03:20:05Z

@Mrtenz

bump of @metamask/utils: deps: @metamask/utils@^6.2.0->^8.1.0 #1639
changing to @metamask/rpc-errors in approval-controller: deps(approval-controller): move to @metamask/rpc-errors #1743

Should unlock bumping @metamask/json-rpc-engine and remaing in updates in permission-controller here.

legobeat

Will need rebase on main, though see note about parallel PRs with some overlapping changes to this one.

## Explanation This replaces obsolete `eth-rpc-errors` with `@metamask/rpc-errors` in `@metamask/approval-controller`. This should be coupled with #1639 and can be merged before or after. ## References #### Broken out from - #1731 #### Blocking - #1724 #### Related - #1690 ## Changelog ### `@metamask/approval-controller` - **Changed**: Replaced `eth-rpc-errors` with `@metamask/rpc-errors` ### `@metamask/controller-utils` - **Fixed**: Removed unused dependency `eth-rpc-errors` ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate

legobeat · 2023-10-19T00:03:37Z

Superseded by #1749

Update @metamask/json-rpc-engine and @metamask/utils

dc43c08

Mrtenz requested review from a team as code owners September 26, 2023 10:44

Mrtenz requested a review from legobeat September 26, 2023 10:45

Fix type errors in permission controller tests

93f6ede

Patch @metamask/rpc-methods

2a1179d

Mrtenz commented Sep 26, 2023

View reviewed changes

Update formatting

852c1e9

This was referenced Sep 26, 2023

Align ESLint, Prettier packages and configs with core monorepo ahead of migration MetaMask/eth-json-rpc-provider#28

Merged

deps: @metamask/utils@^6.2.0->^8.1.0 #1639

Merged

legobeat mentioned this pull request Sep 27, 2023

Use @metamask/rpc-errors in approval-controller #1731

Closed

3 tasks

legobeat mentioned this pull request Sep 29, 2023

deps(approval-controller): move to @metamask/rpc-errors #1743

Merged

3 tasks

legobeat suggested changes Sep 29, 2023

View reviewed changes

legobeat mentioned this pull request Oct 2, 2023

deps(permission-controller): update to @metamask/json-rpc-engine, @metamask/rpc-errors #1749

Merged

3 tasks

legobeat closed this Oct 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update `@metamask/json-rpc-engine` and `@metamask/utils`#1724

Update `@metamask/json-rpc-engine` and `@metamask/utils`#1724
Mrtenz wants to merge 4 commits intomainfrom
mrtenz/json-rpc-engine-and-utils

Mrtenz commented Sep 26, 2023 •

edited

Loading

Uh oh!

Mrtenz commented Sep 26, 2023 •

edited

Loading

Uh oh!

Mrtenz Sep 26, 2023

Uh oh!

Mrtenz commented Sep 26, 2023

Uh oh!

legobeat commented Sep 27, 2023 •

edited

Loading

Uh oh!

Mrtenz commented Sep 27, 2023

Uh oh!

legobeat commented Sep 29, 2023

Uh oh!

legobeat left a comment

Uh oh!

legobeat commented Oct 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		"@metamask/rpc-methods@^0.38.1-flask.1": "patch:@metamask/rpc-methods@npm%3A0.38.1-flask.1#./.yarn/patches/@metamask-rpc-methods-npm-0.38.1-flask.1-081e1eb5b3.patch",
		"@metamask/rpc-methods@^1.0.1": "patch:@metamask/rpc-methods@npm%3A0.38.1-flask.1#./.yarn/patches/@metamask-rpc-methods-npm-0.38.1-flask.1-081e1eb5b3.patch"

Uh oh!

Conversation

Mrtenz commented Sep 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

Changelog

@metamask/accounts-controller

@metamask/address-book-controller

@metamask/approval-controller

@metamask/assets-controller

@metamask/base-controller

@metamask/controller-utils

@metamask/ens-controller

@metamask/gas-fee-controller

@metamask/keyring-controller

@metamask/message-manager

@metamask/network-controller

@metamask/notification-controller

@metamask/permission-controller

@metamask/signature-controller

@metamask/transaction-controller

Checklist

Uh oh!

Mrtenz commented Sep 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mrtenz Sep 26, 2023

Choose a reason for hiding this comment

Uh oh!

Mrtenz commented Sep 26, 2023

Uh oh!

legobeat commented Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mrtenz commented Sep 27, 2023

Uh oh!

legobeat commented Sep 29, 2023

Uh oh!

legobeat left a comment

Choose a reason for hiding this comment

Uh oh!

legobeat commented Oct 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Mrtenz commented Sep 26, 2023 •

edited

Loading

`@metamask/accounts-controller`

`@metamask/address-book-controller`

`@metamask/approval-controller`

`@metamask/assets-controller`

`@metamask/base-controller`

`@metamask/controller-utils`

`@metamask/ens-controller`

`@metamask/gas-fee-controller`

`@metamask/keyring-controller`

`@metamask/message-manager`

`@metamask/network-controller`

`@metamask/notification-controller`

`@metamask/permission-controller`

`@metamask/signature-controller`

`@metamask/transaction-controller`

Mrtenz commented Sep 26, 2023 •

edited

Loading

legobeat commented Sep 27, 2023 •

edited

Loading