Stale user deletion #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
could move the current 24hr window to a .env variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've assumed a stale user is one whose database entry hasn't been updated in 24hrs, who doesn't have payment or email confirmation data on the record. That 24hour variable could be pulled out to the .env if needed.
The idea is you can run
docker compose run --rm artisan users:delete-stalemanually ordocker compose run --rm artisan users:delete-stale --forceon a cron/scheduled job on the server/within Laravel, every hour or so.It will check the database and do a hard delete of any of those users (not just setting their
deleted_atfield). I'm not checking for other data, posts, comments etc-- as the database will deny the deletion because of the referential data.While I was in there, I also just tweaked the user profile page, so now it's reading the joined date from the database, not just a static value.
fixes #20