Skip to content

ILEX-107 Search results pagination footer#98

Merged
ddelpiano merged 4 commits intodevelfrom
feature/ILEX-107
May 9, 2025
Merged

ILEX-107 Search results pagination footer#98
ddelpiano merged 4 commits intodevelfrom
feature/ILEX-107

Conversation

@Aiga115
Copy link

@Aiga115 Aiga115 commented May 6, 2025

Issue #ILEX-107
Problem: Search results pagination footer
Solution:

  1. Add custom pagination component
  2. Connect to elastic search function and provide size and from props to pagination
  3. Handle Select component logic

Result:

Recording.2025-05-07.000128.mp4

@Aiga115 Aiga115 requested a review from ddelpiano May 6, 2025 22:01
const [numberOfVisiblePages, setNumberOfVisiblePages] = React.useState(20);
const [listView, setListView] = React.useState('list');
const getPaginationSettings = (totalItems) => {
const largeDatasetOptions = [20, 50, 100, 200, 500];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aiga115 can we limit the bigger numeber to 100? Thanks!


let defaultSize;
if (totalItems >= 1000) defaultSize = 100;
else if (totalItems >= 500) defaultSize = 100;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this as well in case

let defaultSize;
if (totalItems >= 1000) defaultSize = 100;
else if (totalItems >= 500) defaultSize = 100;
else if (totalItems >= 200) defaultSize = 50;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this

@ddelpiano ddelpiano merged commit 92d381a into devel May 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants