Hook to verify user settings and session validity#107
Merged
Conversation
Aiga115
reviewed
May 23, 2025
Aiga115
left a comment
Aiga115
left a comment
There was a problem hiding this comment.
Great work @ddelpiano! However i noticed one issue, it might not be related to your code though
but when i go back to main page it loses user information for a while
Recording.2025-05-23.154104.mp4
Member
Author
Thanks @Aiga115 , it should be fixed with the latest commit, that was due the logo using a href and so it's an app reload with the useEffect on App.jsx that has to be evaluated again, I replaced that with a navigate which will move to the / but keep the same session alive and so the state. |
|
Looks good to me, tested locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.