Timing Mod wrapper rewrite #80
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedbakerMO
force-pushed
the
68_timing_mod_migration
branch
from
9af43b1 to
b79dcf7
Compare
github-actions
bot
added
cla-signed
…suite config updated
jedbakerMO
force-pushed
the
68_timing_mod_migration
branch
from
5bd2673 to
43c3560
Compare
28 tasks
yaswant
requested review from
christophermaynard
and removed request for
mo-rickywong
Author
|
Some documentation will need to be added for users trying to change the timing system. By default, LFRic Core will use Vernier and LFRic Apps will use Timer. To change from these, the suite configuration variables need to be changed, eg. In rose-stem/site/meto/common/suite_config_ex1a.cylc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @christophermaynard
Code Reviewer: @mo-rickywong
This PR is the github migration of Trac : lfric_apps#958
It replaces all timer calls throughout LFRic Apps and LFRic Core (in the linked PR) with the new timing wrapper. The timing wrapper can use either the current timer or Vernier, depending on suite configuration.
linked MetOffice/lfric_core/pull/201
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
style guidelines
readability of the code
Testing
acceptable (eg. kgo changes)
tests, unit tests, etc.)
and have tests been allocated to an appropriate testing group (i.e. the
developer tests are for jobs which use a small amount of compute resource
and complete in a matter of minutes)
trac.log
Test Suite Results - lfric_apps - timing_mod_apps_updated/run2
Suite Information
Task Information
✅ succeeded tasks - 1104
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
PSyclone Approval
inteface, optimisation scripts, LFRic data structure code) then please
contact the
tooscollabdevteam@metoffice.gov.uk
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review