Add SLEEF acceleration for trigonometric and power functions #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend SLEEF coverage to include sin, cos, tan, asin, acos, atan, and atan2 functions in Eidos. These functions now use SLEEF vectorization when operating on float arrays, with scalar fallback for integer inputs. Changes: - sleef_config.h: Add SLEEF macros for trig functions (AVX2 + ARM NEON) - eidos_simd.h: Add SIMD wrapper functions for all 7 trig functions - eidos_functions_math.cpp: Update trig functions to use SIMD path - eidos_test_functions_math.cpp: Add C++ level tests comparing SLEEF output against scalar std:: functions for numerical correctness SLEEF functions now accelerated: exp, log, log10, log2, sin, cos, tan, asin, acos, atan, atan2 (11 total, up from 4)
- Add EIDOS_SLEEF_POW_D macro for AVX2 and ARM NEON in sleef_config.h - Add pow_float64(), pow_float64_scalar_exp(), and pow_float64_scalar_base() wrapper functions in eidos_simd.h - Update Eidos ^ operator in eidos_interpreter.cpp to use SLEEF pow - Update SpatialMap::power() in spatial_map.cpp to use SLEEF pow - Add C++ unit tests for pow functions in eidos_test_functions_math.cpp
Collaborator
Author
|
interesting... a few tests a failing. i'll investigate. |
Collaborator
Author
|
okay @bhaller this should be ready to merge |
Contributor
Beautiful work! I really like how you designed the tests. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New SIMD-accelerated functions
Trigonometric (via SLEEF):
Power:
Performance improvements
Benchmarks on 1M elements show significant speedups:
Implementation details
Files changed