Add unit tests for spatial kernel SIMD implementations #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
as expected-- two tests are failing in CI: FAILURE count: 2
SUCCESS count: 36837this is good. @bhaller, next I'll issue a separate PR with the patch on the original implementation of the Student's T kernel. Once that is merged we can rerun these tests and they should all go green |
This was referenced Dec 17, 2025
andrewkern
force-pushed
the
simd_spatial_interaction
branch
from
0fa2bab to
5629406
Compare
Add comprehensive tests comparing SIMD kernel implementations against scalar paths to ensure consistency. Tests cover all kernel types: Linear, Exponential, Normal, Cauchy, and Student's T. Key additions: - Individual kernel value tests verifying formulas at known distances - SIMD vs scalar consistency tests using i1.strength() vs i1.totalOfNeighborStrengths() to compare code paths - Tests for 1D, 2D, and multi-individual scenarios - C++ level tests calling SIMD functions directly with 1000 random values
andrewkern
force-pushed
the
simd_spatial_interaction
branch
from
5629406 to
07de8ec
Compare
Collaborator
Author
|
okay this is all green! 🟢 ready to merge @bhaller |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds comprehensive tests for spatial interaction kernel calculations:
All five kernel types covered: Linear, Exponential, Normal, Cauchy, Student's T.
Note: Two tests fail, exposing a pre-existing bug in the scalar tdist() function (see #591)