Skip to content

Styled square tree#47

Open
daisieh wants to merge 45 commits intoMesquiteProject:masterfrom
daisieh:styled-square-tree
Open

Styled square tree#47
daisieh wants to merge 45 commits intoMesquiteProject:masterfrom
daisieh:styled-square-tree

Conversation

@daisieh
Copy link
Copy Markdown
Member

@daisieh daisieh commented Oct 17, 2016

Apparently I’d finished this two years ago but never merged it. Styled Square Tree renders the parts of branches as lines instead of polygons and allows variable branch widths.

@daisieh
Copy link
Copy Markdown
Member Author

daisieh commented Oct 17, 2016

I am attaching a test file here...zipped, because GitHub won't let me drop a raw nexus file.
met1_sanger_tram_phyML.xml.xml.nex.zip

@DMaddison
Copy link
Copy Markdown
Contributor

Thanks, Daisie. Too bad we didn't communicate more. I had built Square Line Tree, which has at least the two basic properties you mention, sometime around four years ago. It was the default tree drawer when Mesquite 3.0 was released in 2014. Was there much else in your code beyond those two properties (branches as lines, variable width)?

@daisieh
Copy link
Copy Markdown
Member Author

daisieh commented Oct 17, 2016

I have no idea! I'm sure I can use Square Line Tree instead of this, but I had used it to build some of the NexSS features, so I'll have to refactor those to build on yours instead. It's fine.

@DMaddison
Copy link
Copy Markdown
Contributor

This is an example of why we need to get out development process more in line with standards, if Wayne and I can manage it. Although we advertise that the core development fork is wmaddisn/MesquiteCore, since we do our process in what seems to be an atypical way, folks don't look for the latest code there. We should have a Skype with Wayne soon to hammer out the best workflow for code that works with us.

@daisieh
Copy link
Copy Markdown
Member Author

daisieh commented Oct 29, 2016

I'm still in the midst of looking through the code for SquareLineTree, but does it handle varying edge width per branch, i.e. thick lines for high support values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants