Skip to content

Fix external antenna radio button layout by reordering labels #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrAlders0n merged 1 commit into from
Jan 4, 2026
Merged

Fix external antenna radio button layout by reordering labels #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,14 @@ <h2 class="text-sm font-medium text-slate-300 uppercase tracking-wide">Settings<
External Antenna <span class="text-amber-400">⚠️ Required</span>
</label>
<div style="display: flex; gap: 0.5rem;">
<label style="flex: 1; display: flex; align-items: center; justify-content: center; padding: 0.5rem 0.75rem; border-radius: 0.5rem; border: 1px solid #475569; cursor: pointer;" class="hover:bg-slate-700 has-[:checked]:bg-emerald-600 has-[:checked]:border-emerald-600">
<input type="radio" name="externalAntenna" value="YES" class="sr-only">
<span class="text-sm font-medium">Yes</span>
</label>
<label style="flex: 1; display: flex; align-items: center; justify-content: center; padding: 0.5rem 0.75rem; border-radius: 0.5rem; border: 1px solid #475569; cursor: pointer;" class="hover:bg-slate-700 has-[:checked]:bg-emerald-600 has-[:checked]:border-emerald-600">
<input type="radio" name="externalAntenna" value="NO" class="sr-only">
<span class="text-sm font-medium">No</span>
</label>
<label style="flex: 1; display: flex; align-items: center; justify-content: center; padding: 0.5rem 0.75rem; border-radius: 0.5rem; border: 1px solid #475569; cursor: pointer;" class="hover:bg-slate-700 has-[:checked]:bg-emerald-600 has-[:checked]:border-emerald-600">
<input type="radio" name="externalAntenna" value="YES" class="sr-only">
<span class="text-sm font-medium">Yes</span>
</label>
Comment on lines 126 to +132
Copy link

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The radio button order "No/Yes" is unconventional for binary choices. Standard UI/UX practice places affirmative options (Yes) before negative options (No) to match user expectations and improve usability. Consider reverting to the Yes/No order to follow established design patterns.

Suggested change
<input type="radio" name="externalAntenna" value="NO" class="sr-only">
<span class="text-sm font-medium">No</span>
</label>
<label style="flex: 1; display: flex; align-items: center; justify-content: center; padding: 0.5rem 0.75rem; border-radius: 0.5rem; border: 1px solid #475569; cursor: pointer;" class="hover:bg-slate-700 has-[:checked]:bg-emerald-600 has-[:checked]:border-emerald-600">
<input type="radio" name="externalAntenna" value="YES" class="sr-only">
<span class="text-sm font-medium">Yes</span>
</label>
<input type="radio" name="externalAntenna" value="YES" class="sr-only">
<span class="text-sm font-medium">Yes</span>
</label>
<label style="flex: 1; display: flex; align-items: center; justify-content: center; padding: 0.5rem 0.75rem; border-radius: 0.5rem; border: 1px solid #475569; cursor: pointer;" class="hover:bg-slate-700 has-[:checked]:bg-emerald-600 has-[:checked]:border-emerald-600">
<input type="radio" name="externalAntenna" value="NO" class="sr-only">
<span class="text-sm font-medium">No</span>
</label>

Copilot uses AI. Check for mistakes.
</div>
</div>

Expand Down