Fix mobile BLE scan stream completion and cleanup#8
Open
robekl wants to merge 1 commit intoMeshMapper:devfrom
Open
Fix mobile BLE scan stream completion and cleanup#8robekl wants to merge 1 commit intoMeshMapper:devfrom
robekl wants to merge 1 commit intoMeshMapper:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes mobile BLE scan stream lifecycle so scan flows complete reliably and do not hang waiting for stream termination.
Problem
MobileBluetoothService.scanForDevices()yielded a controller stream that was never guaranteed to close.This could leave callers waiting on
onDoneindefinitely and keep UI scan state stuck.Changes
_scanControllerto track the active scan stream controller.scanForDevices():controller.add(...)with!controller.isClosed.FlutterBluePlus.isScanningand close the controller when scanning stops.finally.stopScan():_scanControllerif still open._scanControllerreference after cleanup.Why this works
The scan stream now has explicit termination paths for:
isScanning == false)stopScan())finally)So the consumer can consistently receive stream completion and unblock scan UI logic.