Prevent duplicate GPS stream subscriptions on restart#6
Open
robekl wants to merge 1 commit intoMeshMapper:devfrom
Open
Prevent duplicate GPS stream subscriptions on restart#6robekl wants to merge 1 commit intoMeshMapper:devfrom
robekl wants to merge 1 commit intoMeshMapper:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
GpsService.startWatching()idempotent by preventing multiple concurrent GPS position stream subscriptions.Problem
startWatching()could be called multiple times (for example, after permission flows), but it created a newgetPositionStreamsubscription without first cancelling the previous one.This risks duplicate location events, extra processing, and increased battery usage.
Changes
startWatching():_positionSubscriptionWhy this works
At most one active position stream subscription is maintained, so repeated
startWatching()calls restart cleanly instead of stacking listeners.