This repository was archived by the owner on Nov 27, 2021. It is now read-only.
Open
Conversation
Lossless compression made with the Leanify tool.
Owner
|
I am curious why you proposed this? is there a significant gain to CC:R/T for doing this? |
Author
I don't think so, and even if, the difference should be marginal but if the jar size can be smaller without a drawback then why not? |
Owner
|
Enable Pre-Commit, and Github actions on your fork, make sure both checks validate as the mod currently is not compiling through github actions |
MariaTheDinkus
suggested changes
Oct 12, 2021
Owner
|
We will have to think on this one as currently it provides a full megabyte size reduction from the current build |
|
another proposition would be to just use ImgBot? |
Author
Owner
|
could you re-open this PR here? also enable pre-commit and please the linter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lossless compression made with the Leanify tool.