Skip to content
This repository was archived by the owner on Nov 27, 2021. It is now read-only.

Assets optimization#77

Open
K0-RR wants to merge 4 commits intoMerith-TK:1.17.1from
K0-RR:optimize-assets
Open

Assets optimization#77
K0-RR wants to merge 4 commits intoMerith-TK:1.17.1from
K0-RR:optimize-assets

Conversation

@K0-RR
Copy link
Copy Markdown

@K0-RR K0-RR commented Oct 12, 2021

Lossless compression made with the Leanify tool.

Lossless compression made with the Leanify tool.
@Merith-TK
Copy link
Copy Markdown
Owner

I am curious why you proposed this? is there a significant gain to CC:R/T for doing this?

@K0-RR
Copy link
Copy Markdown
Author

K0-RR commented Oct 12, 2021

is there a significant gain to CC:R/T for doing this?

I don't think so, and even if, the difference should be marginal but if the jar size can be smaller without a drawback then why not?

@Merith-TK
Copy link
Copy Markdown
Owner

Enable Pre-Commit, and Github actions on your fork, make sure both checks validate as the mod currently is not compiling through github actions

Copy link
Copy Markdown
Collaborator

@MariaTheDinkus MariaTheDinkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second commit breaks our fabric.mod.json.

@Merith-TK
Copy link
Copy Markdown
Owner

We will have to think on this one as currently it provides a full megabyte size reduction from the current build

@ImUrX
Copy link
Copy Markdown

ImUrX commented Oct 13, 2021

another proposition would be to just use ImgBot?

@K0-RR
Copy link
Copy Markdown
Author

K0-RR commented Oct 13, 2021

@ImUrX I have Imgbot set up to run on every repo I create so it did its optimization after forking this project. Imgbot is better than nothing but there are a few tools that are better for lossless png compression.
Here you can see Imgbot's PR: K0-RR#1

@Merith-TK
Copy link
Copy Markdown
Owner

Merith-TK commented Oct 18, 2021

cc-tweaked/cc-restitched

could you re-open this PR here? also enable pre-commit and please the linter.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants