Skip to content

Move LevelMaps loading to RoomsToLoad loading #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Goganidze wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Move LevelMaps loading to RoomsToLoad loading #234

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cea683
LevelMaps loading is also deferred
Goganidze Feb 16, 2026
072d320
remove commented code
Goganidze Feb 16, 2026
5e16a25
1
Goganidze Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions scripts/stageapi/core/saveSystem.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ StageAPI.LogMinor("Loading Save System")

StageAPI.SaveDataLoaded = false
StageAPI.RoomsToLoad = {}
StageAPI.LevelMapsToLoad = {}

function StageAPI.TryLoadModData(continued)
if Isaac.HasModData(mod) and continued then
Expand Down Expand Up @@ -230,9 +231,9 @@ function StageAPI.LoadSaveString(str)
end
end

StageAPI.LevelMaps = {}
StageAPI.LevelMapsToLoad = {}
for _, levelMapSaveData in ipairs(decoded.LevelMaps) do
StageAPI.LevelMap({SaveData = levelMapSaveData})
StageAPI.LevelMapsToLoad[#StageAPI.LevelMapsToLoad+1] = levelMapSaveData
end

StageAPI.CurrentLevelMapID = decoded.CurrentLevelMapID
Expand Down Expand Up @@ -468,10 +469,15 @@ local function NewLevelLoad()
StageAPI.RoomsToLoad[i] = nil
end

for i = #StageAPI.LevelMapsToLoad, 1, -1 do
StageAPI.LevelMap({SaveData = StageAPI.LevelMapsToLoad[i]})
StageAPI.LevelMapsToLoad[i] = nil
end

StageAPI.SaveModData()
end

mod:AddCallback(ModCallbacks.MC_POST_NEW_LEVEL, NewLevelLoad)
mod:AddPriorityCallback(ModCallbacks.MC_POST_NEW_ROOM, CallbackPriority.IMPORTANT, NewLevelLoad)
mod:AddCallback(ModCallbacks.MC_POST_GAME_STARTED, function (_, isContinued)
-- Needs to trigger also when loading a level
if isContinued then
Expand Down