Skip to content

Fix displaying package author for "External timelines"#55

Open
Pawe1 wants to merge 1 commit intoMemnarch:masterfrom
Pawe1:FixExternalAuthor
Open

Fix displaying package author for "External timelines"#55
Pawe1 wants to merge 1 commit intoMemnarch:masterfrom
Pawe1:FixExternalAuthor

Conversation

@Pawe1
Copy link
Contributor

@Pawe1 Pawe1 commented Aug 30, 2017

Just a quick fix

@Pawe1 Pawe1 changed the title Fix for package "Author" for "External timelines" Fix displaying package author for "External timelines" Aug 30, 2017
@Memnarch
Copy link
Owner

this will currently hide the Github-Repository owner in favor o fthe remote-repository author, right?

@Pawe1
Copy link
Contributor Author

Pawe1 commented Aug 31, 2017

Yes - in case of "remote timeline"
I don't know if this is the best solution but for me it seems as better idea than current one...

@Memnarch
Copy link
Owner

i favor the Githubrepo owner over the external right now, since the Github owner is in charge of the packagemaintanence

@Pawe1
Copy link
Contributor Author

Pawe1 commented Aug 31, 2017

Yes/no...

It is exactly a maintainer - but captioned as "Author" and it is not fair to override author signature...
Maybe in case of external repos Delphinus should display both? (so we need to add "Mainatiner" label)

@Memnarch
Copy link
Owner

Memnarch commented Sep 1, 2017

Yep adding it was one of my planned things. I think that's what i'll favour. Unfortunately i am not at home during the weekend. So this'll need some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants