-
Notifications
You must be signed in to change notification settings - Fork 67
ci: update Spectrum-X Operator STIG components (Ubuntu: 87b43f6-ubuntu, RHEL: 87b43f6-rhel) #2097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update Spectrum-X Operator STIG components (Ubuntu: 87b43f6-ubuntu, RHEL: 87b43f6-rhel) #2097
Conversation
…87b43f6-rhel Signed-off-by: nvidia-ci-cd <svc-cloud-orch-gh@nvidia.com>
Greptile OverviewGreptile SummaryThis PR updates the version strings for Spectrum-X Operator STIG FIPS components from semantic versioning format to short commit hash format. Key Changes:
Critical Issues:
Confidence Score: 2/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant CI as CI System (nvidia-ci-cd)
participant PR as Pull Request
participant ReleaseYAML as hack/release.yaml
participant Workflow as .github/workflows/release.yaml
participant Registry as nvcr.io/nvstaging/mellanox
Note over CI,Registry: Automated Component Version Update
CI->>ReleaseYAML: Update spectrumXOperatorStigFipsRhel version
CI->>ReleaseYAML: network-operator-v26.1.0-beta.5-stig-fips-rhel → 87b43f6-rhel
CI->>ReleaseYAML: Update spectrumXOperatorStigFipsUbuntu version
CI->>ReleaseYAML: network-operator-v26.1.0-beta.5-stig-fips-ubuntu → 87b43f6-ubuntu
CI->>PR: Create PR #2097 with changes
Note over Workflow,Registry: Expected Release Process Flow
Workflow->>ReleaseYAML: Read component definitions
Workflow->>Workflow: Parse STIG FIPS components
Workflow->>Workflow: Apply version pattern: ${COMPONENT_TAG}-stig-fips-${flavor}
Note over Workflow: ⚠️ Expects format like:<br/>network-operator-v26.1.0-beta.5-stig-fips-rhel
Workflow->>Registry: Pull image with constructed tag
Registry-->>Workflow: ❌ May fail if 87b43f6-rhel doesn't match expected pattern
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 2 comments
| repository: nvcr.io/nvstaging/mellanox | ||
| sourceRepository: spectrum-x-operator | ||
| version: network-operator-v26.1.0-beta.5-stig-fips-rhel | ||
| version: 87b43f6-rhel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version format 87b43f6-rhel is inconsistent with all other STIG FIPS components in this file, which use the pattern network-operator-v{VERSION}-stig-fips-{os} (e.g., line 36: network-operator-v26.1.0-beta.5-stig-fips). The release workflow at .github/workflows/release.yaml:172-179 expects STIG FIPS components to follow the ${COMPONENT_TAG}-stig-fips-${component_flavor} format. This short hash format may cause the automated release process to fail.
| repository: nvcr.io/nvstaging/mellanox | ||
| sourceRepository: spectrum-x-operator | ||
| version: network-operator-v26.1.0-beta.5-stig-fips-ubuntu | ||
| version: 87b43f6-ubuntu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version format 87b43f6-ubuntu is inconsistent with all other STIG FIPS components in this file, which use the pattern network-operator-v{VERSION}-stig-fips-{os}. The release workflow at .github/workflows/release.yaml:172-179 expects STIG FIPS components to follow the ${COMPONENT_TAG}-stig-fips-${component_flavor} format. This short hash format may cause the automated release process to fail.
Automated CI update for components 'spectrumXOperatorStigFipsUbuntu' and 'spectrumXOperatorStigFipsRhel', created by internal GitLab CI for release branch network-operator-26.1.x.