-
Notifications
You must be signed in to change notification settings - Fork 171
[CI] issue: 4705805 Move doca-host installation to image #1156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
887764b to
c700368
Compare
Greptile OverviewGreptile SummaryThis PR moves DOCA installation from CI runtime to Docker image build time, improving CI performance and reducing network-related failures. Key changes:
The RHEL version fix in Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant CI as CI Pipeline
participant DockerBuild as Docker Build Process
participant BaseImage as Base Image
participant DocaScript as doca_install.sh
participant DocaRepo as DOCA Repository
participant FinalImage as Final Docker Image
Note over CI,FinalImage: Before this PR: Runtime Installation
CI->>BaseImage: Pull base image
CI->>CI: Run container from base image
CI->>DocaScript: Execute doca_install.sh at runtime
DocaScript->>DocaRepo: Download DOCA packages (network call)
DocaRepo-->>DocaScript: Return packages
DocaScript->>CI: Install DOCA in running container
CI->>CI: Continue with build/test steps
Note over CI,FinalImage: After this PR: Build-Time Installation
CI->>DockerBuild: Trigger image build
DockerBuild->>BaseImage: FROM base image
DockerBuild->>DockerBuild: COPY doca_install.sh to /tmp
DockerBuild->>DocaScript: RUN doca_install.sh during build
DocaScript->>DocaRepo: Download DOCA packages (network call)
DocaRepo-->>DocaScript: Return packages
DocaScript->>DockerBuild: Install DOCA in image layer
DockerBuild->>DockerBuild: Cleanup temp files
DockerBuild->>FinalImage: Build complete with DOCA pre-installed
CI->>FinalImage: Pull pre-built image with DOCA
CI->>CI: Continue with build/test steps (faster)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 2 comments
c700368 to
31ddf84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9 files reviewed, no comments
31ddf84 to
953fbbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9 files reviewed, no comments
953fbbd to
0bccd45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 files reviewed, no comments
Install doca-host during image build instead of runtime to reduce ci duration and avoid network failures. Signed-off-by: Noam Tsemah <ntsemah@nvidia.com>
0bccd45 to
e192543
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 files reviewed, no comments
|
bot:retest |
Description
Please provide a summary of the change.
What
Install doca-host during image build instead of runtime
Why ?
HPCINFRA-4061
reduce ci duration and avoid network failures
How ?
It is optional but for complex PRs please provide information about the design,
architecture, approach, etc.
Change type
What kind of change does this PR introduce?
Check list