Ensure tab callbacks cancelled before cleanup #3465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

MelkorBalrog wants to merge 1 commit into main from codex/audit-tab-management-for-cleanup-routines

Owner

MelkorBalrog commented Sep 4, 2025

Summary

cancel Tk after callbacks before forgetting or destroying tabs to avoid orphaned Tcl commands
document callback cancellation in ClosableNotebook and update version history

Testing

radon cc -j gui/utils/closable_notebook.py
pytest (fails: Segmentation fault)
pytest tests/test_closable_notebook.py tests/detachment/after_callbacks/test_tab_close_cleanup.py (all skipped)

https://chatgpt.com/codex/tasks/task_b_68b97c3d25f08327babe354aba93480e


          Cancel tab callbacks before widget cleanup

eaf5796

MelkorBalrog added the codex label

— with

ChatGPT Codex Connector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels