Run splash close from main thread #3324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

MelkorBalrog wants to merge 1 commit into main from codex/fix-tcl_asyncdelete-thread-error-uz68lh

Owner

MelkorBalrog commented Aug 29, 2025

Summary

close the splash screen from the Tk main thread using an event flag and polling loop to avoid Tcl_AsyncDelete
extend SplashLauncher tests to cover background loading and main thread invocation
record the fix in HISTORY and bump version to 0.2.207

Testing

radon cc -s -j gui/windows/splash_screen.py tools/splash_launcher.py tests/test_splash_screen.py tests/test_splash_launcher.py > /tmp/cc.json
pytest (fails: tests/test_app_drag_undo_redo.py::test_app_drag_undo_redo, tests/test_app_hotkey_undo_redo.py::test_app_hotkey_undo_redo, tests/test_app_mixins.py::test_app_mixins, tests/test_arch_window_focus.py::test_arch_window_focus, tests/test_auto_paste_gsn_clone.py::test_auto_paste_gsn_clone, ...)

https://chatgpt.com/codex/tasks/task_b_68b0a44dde0c8327ae6da36a34f1b5e6


          Run splash close from main thread

a9dc07b

MelkorBalrog added the codex label

— with

ChatGPT Codex Connector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels