TeX: Fix uploading#193
Conversation
+ Extension now instantly sends image. My fix is heavily inspired by https://github.com/Yentis/betterdiscord-emotereplacer/blob/master/src/services/modulesService.ts. Especially cloudUploader. + "Attach" button is renamed to "Send" to reflect this change.
+ Search for uploader and cloudUploader on plugin start and cache reference as attributes of TeX class.
+ Use same functions that Discord API calls when user attaches a file + Cache attachmentManager reference in start so that it only gets searched once + Rename confirmButton of modal back to 'Attach'
+ button text color is black, may get around to fixing some other time
|
The Text Button still looks unstyled for me. Is this something that's supposed to be fixed already? I played around with the styles and managed to get it to look more like the other buttons, although it's mostly through inline styling. |
|
Discord changed their internals on buttons. My commit fae64d0 was about this. After it, the styling got broken. I'm happy that TeX works like it should, which was the main goal of this PR, so I didn't invest any more time. Perhaps someone else can find a way to keep the styling. |
|
Discord has pushed out massive changes to their internals. I'm waiting on confirmation that BetterDiscord as well as ZeresPluginLibrary is fixed while I investigate what has changed regarding uploading, etc.. I will then push an update once I find time. |
|
BetterDiscord update has fixed functionality of TeX for me. Please let me know if anyone is facing any issues still. |
|
This doesn't seem to be workin but I'm unsure as I don't know exactly how to use the plugin. Couldn't find a guide but I've tried with dollar signs and with backticks ` |
|
Well. i managed to fix it but i got broken yesterday as the new update broke it. would anyone help me? |
5 participants
This PR incorporates the fix by Michael-Wigham for the null button and aims to fix uploading issues that remained: #184. Sadly his PR remains open until this day. It works for me!
Edit: I was able to successfully reverse-engineer the current way Discord API handles attachments. My latest commit should restore full functionality of TeX.